-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SineExtraction::init() doesn't reset mBuf #236
Comments
Yes. Or just call |
I don't see a clear() in SinExtraction - am I missing something? |
oh sorry - on mBuf - I don't mind either way but it asserts without something and is liable to crash, so it would be good to fix. @weefuzzy happy to PR whichever you'd prefer. |
Isn't |
Cool, thanks. Very slight aesthetic preference to calling |
Turns out that clear() is not a thing for a queue. |
Well then, that makes our choice. |
Fixed in 7247a36 |
The contents of mBuf should have a consistent size, but if it isn't reset when init() is called this can not be the case (leading to possible crashes or undefined behaviour).
When this object was updated the reset was commented out, but it is needed, so I would propose that:
flucoma-core/include/algorithms/public/SineExtraction.hpp
Line 57 in 2681d58
Should be:
mBuf = makeEmptyQueue(alloc);
Doing so solves an eigen_assert I get with debug builds. @weefuzzy ?
The text was updated successfully, but these errors were encountered: