Skip to content

Commit 7c79391

Browse files
authored
Add developer notes about PR reviewing (#157)
1 parent ac26937 commit 7c79391

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

docs/developer-notes.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
In the Marine we use the following conventions for PR reviewing:
2+
- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
3+
- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them,
4+
- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix,
5+
- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation.

0 commit comments

Comments
 (0)