Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLB_THROTTLE return for outputs #4293

Open
PettitWesley opened this issue Nov 8, 2021 · 3 comments
Open

FLB_THROTTLE return for outputs #4293

PettitWesley opened this issue Nov 8, 2021 · 3 comments
Labels
enhancement long-term Long term issues (exempted by stale bots)

Comments

@PettitWesley
Copy link
Contributor

Fluent Bit's behavior when an output is throttled is not ideal.

If one of my outputs gets a throttling error, I only have 3 choices for what to tell the core pipeline:

  • FLB_OK: the entire chunk was successfully sent/handled
  • FLB_RETRY: retry the entire chunk up to the max user configured retries
  • FLB_ERROR: something went very wrong, don't retry

If I return FLB_RETRY, then that specific chunk will be retried with exponential backoff. However, the pipeline will continue to send my output new chunks. Thus, from the POV of my destination, I am not slowing down and backing off at all, I am continuing to send new data.

Thus, I think we need an FLB_THROTTLE return which would be like a special case for FLB_RETRY. It would tell the core to freeze the output for some period of time, and not send any new chunks. Basically, the core should backoff the entire output instance.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@PettitWesley
Copy link
Contributor Author

I still want this.

@github-actions github-actions bot added the Stale label Mar 14, 2022
@PettitWesley PettitWesley added long-term Long term issues (exempted by stale bots) enhancement and removed Stale labels Mar 14, 2022
@fluent fluent deleted a comment from github-actions bot Mar 14, 2022
@wchaws
Copy link

wchaws commented Nov 16, 2022

related issue: #6369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement long-term Long term issues (exempted by stale bots)
Projects
None yet
Development

No branches or pull requests

2 participants