Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluentd_build_info #40

Open
kfdm opened this issue Nov 14, 2017 · 5 comments
Open

fluentd_build_info #40

kfdm opened this issue Nov 14, 2017 · 5 comments

Comments

@kfdm
Copy link

kfdm commented Nov 14, 2017

For many exporters, there's a bit of metadata that is added to the metrics. For example from Prometheus itself

# HELP prometheus_build_info A metric with a constant '1' value labeled by version, revision, branch, and goversion from which prometheus was built.
# TYPE prometheus_build_info gauge
prometheus_build_info{branch="HEAD",goversion="go1.9.1",revision="3a7c51ab70fc7615cd318204d3aa7c078b7c5b20",version="1.8.1"} 1

or Grafana

# HELP grafana_info Information about the Grafana
# TYPE grafana_info gauge
grafana_info{version="4.6.1"} 1

Would you accept a pull request to add similar metadata to this plugin?
I was thinking something like

fluentd_build_info{rubyversion="??", tdagentversion="??"} 1

Would be useful to help see what was deployed

@repeatedly
Copy link
Member

fluentdversion is better than tdagentversion.
Hard to get tdagentversion from inside fluentd.

@kazegusuri
Copy link
Collaborator

Would you accept a pull request to add similar metadata to this plugin?

yes, I appreciate it.

@kfdm
Copy link
Author

kfdm commented Nov 20, 2017

Sounds good! I'll try to get you a PR in the next few weeks :)

@Jasstkn
Copy link

Jasstkn commented Jun 17, 2022

@kazegusuri hey. any progress here?

@colinleroy
Copy link

Hi,
I'd like to tackle this, but... I'm completely new at Ruby and don't understand the codebase at all. Could someone with more knowledge point me to where I should look / get inspiration from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants