Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails on Ruby HEAD #4584

Closed
Watson1978 opened this issue Aug 8, 2024 · 8 comments
Closed

CI fails on Ruby HEAD #4584

Watson1978 opened this issue Aug 8, 2024 · 8 comments
Labels
bug Something isn't working Non fluentd issue

Comments

@Watson1978
Copy link
Contributor

Watson1978 commented Aug 8, 2024

Describe the bug

Now, CI fails on Ruby HEAD.
https://github.com/fluent/fluentd/actions/runs/10277576606

I investigated this failures and found what webrick raises exception of "uninitialized constant URI::REGEXP (NameError)" at
https://github.com/ruby/webrick/blob/158a7ef85337e0e5cdce0c29cb5cb89c7beb9c53/lib/webrick/httprequest.rb#L507

Seems URI::REGEXP was removed at ruby/uri#107 recently.

And webrick maintainer already fixed this issue at ruby/webrick#144,
but it's not released yet.

This issue should be solved by next release of webrick gem (v1.8.2 or above).

To Reproduce

Run tests with Ruby HEAD

Expected behavior

All tests will be passed.

Your Environment

- Fluentd version:
- Package version:
- Operating system:
- Kernel version:

Your Configuration

none

Your Error Log

https://github.com/fluent/fluentd/actions/runs/10277576606

Additional context

No response

Copy link

github-actions bot commented Sep 7, 2024

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 7 days

@github-actions github-actions bot added the stale label Sep 7, 2024
@Watson1978
Copy link
Contributor Author

don't close this until releasing new version of webrick.

@Watson1978 Watson1978 removed the stale label Sep 9, 2024
@ashie ashie added the bug Something isn't working label Sep 9, 2024
@Watson1978
Copy link
Contributor Author

Webrick v1.8.2 was released
https://github.com/ruby/webrick/releases/tag/v1.8.2

@Watson1978
Copy link
Contributor Author

Seems CI has another failure...

4) Failure: test: failed to start(TestFluentdCommand::configuration to load plugin file with syntax error):
  fluentd failed to start, without specified regular expressions:
  2024-09-25 01:36:55 +0000 [info]: init supervisor logger path=nil rotate_age=nil rotate_size=nil
  2024-09-25 01:36:55 +0000 [info]: parsing config file is succeeded path="/home/runner/work/fluentd/fluentd/test/command/../tmp/commandfluentd/ddc62727292b887b1d0a/buggy_plugin.conf"
  2024-09-25 01:36:55 +0000 [info]: gem 'fluentd' version '1.17.1'
  bundler: failed to load command: /home/runner/work/fluentd/fluentd/bin/fluentd (/home/runner/work/fluentd/fluentd/bin/fluentd)
  /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:79:in 'Kernel.require': --> /home/runner/work/fluentd/fluentd/test/tmp/commandfluentd/ddc62727292b887b1d0a/plugin/in_buggy.rb
  Unmatched keyword, missing `end' ?
  > 2  module Fluent::Plugin
  /home/runner/work/fluentd/fluentd/test/tmp/commandfluentd/ddc62727292b887b1d0a/plugin/in_buggy.rb:6: syntax errors found (SyntaxError)
    4 |     Fluent::Plugin.register_input('buggy', self)
    5 |   end
  > 6 | 
      | ^ expected an `end` to close the `module` statement
  
      | ^ unexpected end-of-input, assuming it is closing the parent top level context
  
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:79:in 'block (2 levels) in Kernel#replace_require'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/registry.rb:69:in 'Fluent::Registry#search'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/registry.rb:44:in 'Fluent::Registry#lookup'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/plugin.rb:169:in 'Fluent::Plugin.new_impl'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/plugin.rb:110:in 'Fluent::Plugin.new_input'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/root_agent.rb:315:in 'Fluent::RootAgent#add_source'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/root_agent.rb:161:in 'block in Fluent::RootAgent#configure'
  	from <internal:array>:42:in 'Array#each'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/root_agent.rb:155:in 'Fluent::RootAgent#configure'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/engine.rb:105:in 'Fluent::EngineClass#configure'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/engine.rb:80:in 'Fluent::EngineClass#run_configure'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/supervisor.rb:572:in 'Fluent::Supervisor#run_supervisor'
  	from /home/runner/work/fluentd/fluentd/lib/fluent/command/fluentd.rb:352:in '<top (required)>'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:79:in 'Kernel.require'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:79:in 'block (2 levels) in Kernel#replace_require'
  	from /home/runner/work/fluentd/fluentd/bin/fluentd:15:in '<top (required)>'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/cli/exec.rb:58:in 'Kernel.load'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/cli/exec.rb:58:in 'Bundler::CLI::Exec#kernel_load'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/cli/exec.rb:23:in 'Bundler::CLI::Exec#run'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/cli.rb:457:in 'Bundler::CLI#exec'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/vendor/thor/lib/thor/command.rb:28:in 'Bundler::Thor::Command#run'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/vendor/thor/lib/thor/invocation.rb:127:in 'Bundler::Thor::Invocation#invoke_command'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/vendor/thor/lib/thor.rb:527:in 'Bundler::Thor.dispatch'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/cli.rb:35:in 'Bundler::CLI.dispatch'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/vendor/thor/lib/thor/base.rb:584:in 'Bundler::Thor::Base::ClassMethods#start'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/cli.rb:29:in 'Bundler::CLI.start'
  	from /home/runner/.rubies/ruby-head/lib/ruby/gems/3.4.0+0/gems/bundler-2.6.0.dev/exe/bundle:28:in 'block in <top (required)>'
  	from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundler/friendly_errors.rb:117:in 'Bundler.with_friendly_errors'

https://github.com/fluent/fluentd/actions/runs/11024560399/job/30617932835

@Watson1978
Copy link
Contributor Author

Watson1978 commented Sep 25, 2024

Maybe the failure is introduced by prism which is new Ruby parser...
ruby/ruby@ea2af57

(At least I have found one problem and reported it. https://bugs.ruby-lang.org/issues/20730)

@daipom
Copy link
Contributor

daipom commented Sep 26, 2024

Done?

@Watson1978
Copy link
Contributor Author

OK, Test with Ruby head was succeeded.
https://github.com/fluent/fluentd/actions/runs/11043658331/job/30678296415

So, we can close this issue.

@daipom
Copy link
Contributor

daipom commented Sep 26, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Non fluentd issue
Projects
None yet
Development

No branches or pull requests

3 participants