Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluentd: Allow users to override pod entrypoint #374

Open
Boojapho opened this issue Jun 1, 2023 · 0 comments · May be fixed by #375
Open

Fluentd: Allow users to override pod entrypoint #374

Boojapho opened this issue Jun 1, 2023 · 0 comments · May be fixed by #375

Comments

@Boojapho
Copy link
Contributor

Boojapho commented Jun 1, 2023

In the fluentd chart, there is no way to override the default entrypoint of the image. It either uses the default or is hard coded to /fluentd/entrypoint.sh (if using plugins). Provide a value to override the entrypoint, with a default of /fluentd/entrypoint.sh.

My suggestion is to always use the pattern:

command:
- "/bin/sh"
- "-c"
- |
  {{- range $plugin := .Values.plugins }}
    {{- print "fluent-gem install " $plugin | nindent 6 }}
  {{- end }}
  exec {{ .Values.podEntrypoint }}

Without plugins, the entrypoint will replace the shell. With plugins, the plugins will install, then the entrypoint will replace the shell. This also allows us to pass additional arguments to the entrypoint without making it into an array.

@Boojapho Boojapho linked a pull request Jun 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant