Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to get rid of "Description:" in every column description? #1783

Open
Lelishe opened this issue Apr 17, 2024 · 5 comments
Open

How to get rid of "Description:" in every column description? #1783

Lelishe opened this issue Apr 17, 2024 · 5 comments
Labels
Milestone

Comments

@Lelishe
Copy link

Lelishe commented Apr 17, 2024

Аfter upgrading to FluentMigrator 5.2.0 in every column description, generated via WithColumnDescription(..) there is a prefix "Description:". We don't use AdditionalColumnDescriptions.
Is it possible to disable this new feature somehow? Or use a feature flag? I'ts hardcoded in GenericDescriptionGenerator.GenerateDescriptionStatements:
string initialDescriptionStatement = GenerateColumnDescription( "Description", expression.SchemaName, expression.TableName, column.Name, "Description:" + column.ColumnDescription);

  • FluentMigrator 5.2.0
  • FluentMigrator runner : in-process
  • Postgresql 14
@martinib77
Copy link

The same is happening to. me. I think is a bug that was introduced with the commit b8dd18d.

@jzabroski
Copy link
Collaborator

@azerios Would you be able to look at this issue for me?

@jzabroski jzabroski added the bug label May 30, 2024
@jzabroski
Copy link
Collaborator

I'll try to address this this week as part of shipping 6.0. Very sorry I didn't catch this in review.

@jzabroski jzabroski added this to the 6.0.0 milestone Jun 8, 2024
@jzabroski
Copy link
Collaborator

I'm almost done fixing this. The remaining issue is that the new AdditionalDescriptions feature doesn't support four types of expressions that otherwise support expressions: AlterTableExpression, CreateColumnExpression, and AlterColumnExpression.

public interface IDescriptionGenerator
{
IEnumerable<string> GenerateDescriptionStatements(CreateTableExpression expression);
string GenerateDescriptionStatement(AlterTableExpression expression);
string GenerateDescriptionStatement(CreateColumnExpression expression);
string GenerateDescriptionStatement(AlterColumnExpression expression);

@jzabroski jzabroski modified the milestones: 6.0.0, 6.1.0 Sep 25, 2024
@jzabroski
Copy link
Collaborator

I've worked on this in my local but not yet ready to ship the full fix.

@jzabroski jzabroski modified the milestones: 6.1.0, 6.3.0 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants