Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should offer to set up build/test GitHub workflow #3

Open
fluffynuts opened this issue Jul 10, 2020 · 0 comments
Open

should offer to set up build/test GitHub workflow #3

fluffynuts opened this issue Jul 10, 2020 · 0 comments

Comments

@fluffynuts
Copy link
Owner

Shouldn't be too hard -- if testing is enabled for the project, include a .github/workflows/ci.yaml with something like:

on: [ push, pull_request ]

jobs:
  main:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - uses: actions/setup-node@v2-beta
      with:
        node-version: '12'
    - name: Test
      run: |
        npm ci
        npm run build
        npm run lint
        npm test

notes:

  • perhaps the build / lint / test should be consolidated as a single npm script
  • node-version set to 12 for now, but perhaps it should track the version of node used by the person creating the project? At the very least, this would mean no need to re-visit this part of the setup periodically
@fluffynuts fluffynuts added hacktoberfest help wanted Extra attention is needed labels Oct 4, 2020
@fluffynuts fluffynuts removed help wanted Extra attention is needed hacktoberfest labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant