-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Eleventy localization features and Eleventy asset processing #337
feat: use Eleventy localization features and Eleventy asset processing #337
Conversation
feat: add gettext support for translations feat: use eleventy-plugin-fluid to process assets feat!: drop Stylus support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Is it just the docs that we're waiting on, or was there something else you'd like to add as well?
I'll move the utility into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Justin Obara <jobara@users.noreply.github.com>
npm run lint
without errorsnpm run start
and reviewing affected routesnpm run build
without errorsDescription
This PR:
eleventy-plugin-fluid
for asset processing, removing Laravel Mix and Stylus support._site
directory for build output.src
with an underscore (_filters
,_locales
,_shortcodes
,_transforms
,_utils
) to match Eleventy conventions (see: https://www.11ty.dev/docs/config/#directory-for-includes, https://www.11ty.dev/docs/config/#directory-for-layouts-(optional)).lint-staged
, rather than runningfluid-lint-all
.Steps to test
Basic behaviour
npm run start
Expected behavior: Content available in French and English is linked properly.
Adding a language
npm run start
Expected behavior: Build functions without errors. Content available in French, English, and the newly added language is linked properly. RSS feed, 404 page, and posts pages are available in the newly added language. CMS functions as expected.
Disabling localization for posts
npm run start
Expected behavior: Build functions without errors. Content available in French, and English is linked properly. RSS feed is only available in the default language and posts pages in both languages show default language content. CMS functions as expected.
Disabling localization for full site
npm run start
Expected behavior: Build functions without errors. Content is only shown in English. RSS feed, posts page and 404 pages are only available in the default language. CMS functions as expected.
Additional information
Not applicable.
Related issues
Not applicable.