-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle controls don't play nice with white accent color #1312
Comments
Hi @NyxCode, thank you for reporting this issue. I can indeed reproduce the problem and will try to somehow improve the situation; however, I have a feeling this will always be a bit of a problem when using colors near white or black... |
@pedrolamas Yeah, no pressure, this is not a dealbreaker for me. |
Fluidd Version
v1.27.1
Browser
Chrome
Device
Desktop PC
Operating System
Linux
What happened
With a white accent color, parts of the circle controls are unreadable.
Homed:
Not homed:
What did you expect to happen
All elements of the controls remain readable
How to reproduce
rgb(255, 255, 255)
Additional information
Setting the font to black if the background is bright enough might be an option.
Not entirely sure how to implement this - maybe by converting the background color to HSL, and setting a threshold for the lightness value at which the text color is changed?
edit: seems like this can be done purely in CSS - cool!
The text was updated successfully, but these errors were encountered: