sh:nodeKind constraints not being enforced correctly

[mpoffald]

It looks like (at least some) sh:nodeKind constraints are letting invalid transactions through.

Here are some tests that should pass, but currently fail:

(deftest ^:integration shacl-nodekind-constraints
  (testing "sh:Literal"
    (let [conn         (test-utils/create-conn)
          ledger       @(fluree/create conn "shacl/b" {:defaultContext ["" {:ex "http://example.org/ns/"}]})
          db-literal-names  @(fluree/stage
                               (fluree/db ledger)
                               {:id             :ex/UserShape
                                :type           [:sh/NodeShape]
                                :sh/targetClass :ex/User
                                :sh/property    [{:sh/path     :schema/name
                                                  ;;cannot be IRI or blank node
                                                  :sh/nodeKind :sh/Literal}]})
          invalid-db-iri-name  (try @(fluree/stage
                                       db-literal-names
                                       {:id          :ex/john
                                        :type        [:ex/User]
                                        :schema/name {:id :ex/Jack}})
                                    (catch Exception e e))
          invalid-db-blank-name  (try
                                   @(fluree/stage
                                      db-literal-names
                                      {:id          :ex/john
                                       :type        [:ex/User]
                                       :schema/name {:ex/firstName "John"}})
                                   (catch Exception e e))]
      (is (util/exception? invalid-db-iri-name))
      (is (util/exception? invalid-db-blank-name))))
  (testing "sh:IRIOrLiteral"
    (let [conn         (test-utils/create-conn)
          ledger       @(fluree/create conn "shacl/b" {:defaultContext ["" {:ex "http://example.org/ns/"}]})
          db-no-blank-countries  @(fluree/stage
                                  (fluree/db ledger)
                                  {:id             :ex/UserShape
                                   :type           [:sh/NodeShape]
                                   :sh/targetClass :ex/User
                                   :sh/property    [{:sh/path     :ex/country
                                                     ;;cannot be blank node
                                                     :sh/nodeKind  :sh/IRIOrLiteral}]})
          invalid-db-blank-country  (try
                                      @(fluree/stage
                                         db-no-blank-countries
                                         {:id          :ex/john
                                          :type        [:ex/User]
                                          :schema/name "John"
                                          :ex/country  {:ex/abbreviation "AU"}})
                                      (catch Exception e e))]
      (is (util/exception? invalid-db-blank-country))))
  (testing "sh:BlankNodeOrLiteral"
    (let [conn         (test-utils/create-conn)
          ledger       @(fluree/create conn "shacl/b" {:defaultContext ["" {:ex "http://example.org/ns/"}]})
          db-no-iri-jobs  @(fluree/stage
                             (fluree/db ledger)
                             {:id             :ex/UserShape
                              :type           [:sh/NodeShape]
                              :sh/targetClass :ex/User
                              :sh/property    [{:sh/path     :ex/occupation
                                                ;;cannot be IRI
                                                :sh/nodeKind :sh/BlankNodeOrLiteral}]})
          invalid-db-iri-job (try
                               @(fluree/stage
                                  db-no-iri-jobs
                                  {:id :ex/john
                                   :type [:ex/User]
                                   :schema/name "John"
                                   :ex/occupation {:id "Developer"}})
                               (catch Exception e e))]
      (is (util/exception? invalid-db-iri-job)))))

This is somewhat related to #533, which requires an sh:nodeKind implementation that specifically works on transacted flakes.

[mpoffald]

Note that there are no existing tests for sh:nodeKind, so it's unclear what may have broken this. Also, I didn't try all of the possible sh:nodeKinds, so it may be that the others work.

[dpetran]

I believe this was fixed and tested in #557.