Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormBuilderStepper won't support double values #182

Closed
VOIDCRUSHER opened this issue Nov 30, 2019 · 4 comments
Closed

FormBuilderStepper won't support double values #182

VOIDCRUSHER opened this issue Nov 30, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@VOIDCRUSHER
Copy link
Contributor

It's a common use case to step with constant non-integer absolute values, as in increments of .5 or .25 to avoid loaded dropdown menus. However, using non-integer values in the FormBuilderStepper will throw the following error:

The following assertion was thrown building FormField<num>-[LabeledGlobalKey<FormFieldState<dynamic>>#e4387](dirty, dependencies: [_FormScope], state: FormFieldState<num>#9d900):
type 'double' is not a subtype of type 'int'

I believe this can be traced all the way up to root SyStepper class used in FormBuilderStepper which declares it's numeric values as int types.

In addition to lobbying for this to be fixed, I think this issue should also open a discussion to hopefully remove all two dependencies on sy_flutter_widgets as the maintainer has signaled there will be no further updates and has no licensing information.

I look forward to any further discussion. Thanks!

@danvick
Copy link
Collaborator

danvick commented Nov 30, 2019

Hi @VOIDCRUSHER,
Thanks for bringing this to my attention. I'll try to make that work ASAP.
I appreciat ethe feedback

@danvick danvick added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 30, 2019
@danvick
Copy link
Collaborator

danvick commented Dec 1, 2019

Now that we don't have our own stepper. I'll consider porting the library to our own library and keep maintaining it.

@danvick danvick closed this as completed in d1da278 Dec 5, 2019
@danvick
Copy link
Collaborator

danvick commented Dec 5, 2019

Fixed in v3.7.0. Feel free to reopen in case of any more feedback.

@VOIDCRUSHER
Copy link
Contributor Author

You beat me to a PR I was about to submit. Left some feedback. Thanks for addressing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants