Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormBuilderDateTimePicker gets Focus on route pop #251

Closed
shashikantleher opened this issue Apr 4, 2020 · 5 comments
Closed

FormBuilderDateTimePicker gets Focus on route pop #251

shashikantleher opened this issue Apr 4, 2020 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@shashikantleher
Copy link

Reproduce:

  • Now on page A
  • Open form page B
  • Change date value
  • Go back (Pops the screen)
  • Date time picker dialog shows in the page B

There is some issue in handling the focus of FormBuilderDateTimePicker. (may be)

@cuimingqiang
Copy link

if (_formKey.currentState.saveAndValidate()) {
FocusScope.of(context).requestFocus(FocusNode());
}

@shashikantleher
Copy link
Author

Yes thank you, @cuimingqiang . That works.

@shashikantleher
Copy link
Author

But, when a date is selected, it should automatically unfocus the date field

@danvick
Copy link
Collaborator

danvick commented Apr 15, 2020

Thank you @shashikantleher, for bringing this to our attention.

Kindly note that this package makes use of other packages so some bugs or issues may emanate from such.

I will try to have a permanent fix, baked into the package.

@cuimingqiang thanks for your solution.
Cheers!

@danvick danvick added bug Something isn't working help wanted Extra attention is needed labels May 7, 2020
@danvick
Copy link
Collaborator

danvick commented Dec 21, 2020

This should be fixed, feel free to reopen if not.

@danvick danvick closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants