Skip to content
This repository has been archived by the owner on Jan 27, 2024. It is now read-only.

Critical: Migration to Federated Plugin [Action plan] #86

Open
iamsahilsonawane opened this issue Aug 11, 2022 · 8 comments
Open

Critical: Migration to Federated Plugin [Action plan] #86

iamsahilsonawane opened this issue Aug 11, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@iamsahilsonawane
Copy link
Member

iamsahilsonawane commented Aug 11, 2022

Description

Firstly, before implementing web support for the plugin. It needs platform separation.

The main package should be platform agnostic. Three different platform-specific packages need to be created instead, along with the platform interface.

So the new package structure should be:

  • phone_number (main)
  • phone_number_platform_inteface
  • phone_number_android
  • phone_number_ios
  • phone_number_web (Web Support #44)

@deandreamatias I need your help here. You can create those remaining repositories on flutter-form-builder-ecosystem.

Roadmap:

  1. Create required subdivision folders
  2. Working out platform interface
  3. Migrating old platform code to platform-specific repos.
  4. Testing (Android, iOS)
  5. Merging the changes into main in actual phone_number repo.
  6. Publishing (platform-specific -> unlisted packages) (@deandreamatias)
@iamsahilsonawane
Copy link
Member Author

We need to do this before web support. It will benefit very much in the long run.

For more information: Article

@iamsahilsonawane iamsahilsonawane pinned this issue Aug 11, 2022
@deandreamatias
Copy link
Contributor

deandreamatias commented Aug 11, 2022

I agree with almost with exception of create new repositories.
We can create new folder for each package, like flutter plugins.

And all work about web support, I would move to existent issue #44

We need use this official doc to this process (that include your linked Article)

@iamsahilsonawane iamsahilsonawane changed the title Critical: Platform Separation & Web Support [Action plan] Critical: Migration to Federated Plugin [Action plan] Aug 11, 2022
@deandreamatias
Copy link
Contributor

@iamsahilsonawane
Copy link
Member Author

@deandreamatias Let's start on this soon.

@deandreamatias
Copy link
Contributor

deandreamatias commented Apr 27, 2023

Maybe can reuse this package https://pub.dev/packages/libphonenumber_plugin

@deandreamatias
Copy link
Contributor

Take a look on this discussion. I think that we need think more about the maintain of this package

natintosh/intl_phone_number_input#201 (comment)

@VictorUvarov
Copy link
Contributor

How much effort is involved in migrating this plugin to a federated plugin?
I would definitely also use pigeon to generate the native code bindings

@deandreamatias
Copy link
Contributor

I don't know if make sense still maintain this plugin. Had some other solutions with the same functionality like:

I wrote about this, here acoutts/flutter_libphonenumber#44 and here natintosh/intl_phone_number_input#201 (comment)

Also, I don't have time to support this plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants