Refactor TextInputChannel (#142)

* Refactor TextInputChannel

* Introduce TizenInputMethodContext

* Remove unnecessary PlatformView APIs

* Tidy up based on review

* Always Send key event to TextInputChannel

* Use #if defined() instead of #ifdef

* Rename to ShouldNotFilterEvent

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

Author: bbrto21

shell/platform/tizen/BUILD.gn

@@ -38,6 +38,7 @@ _flutter_tizen_source = [
   "flutter_tizen_texture_registrar.cc",
   "key_event_handler.cc",
   "tizen_event_loop.cc",
+  "tizen_input_method_context.cc",
   "tizen_renderer.cc",
   "touch_event_handler.cc",
 ]

shell/platform/tizen/channels/platform_view_channel.cc

@@ -8,7 +8,6 @@
 #include "flutter/shell/platform/common/client_wrapper/include/flutter/standard_message_codec.h"
 #include "flutter/shell/platform/common/client_wrapper/include/flutter/standard_method_codec.h"
 #include "flutter/shell/platform/common/json_method_codec.h"
-#include "flutter/shell/platform/tizen/channels/text_input_channel.h"
 #include "flutter/shell/platform/tizen/flutter_tizen_engine.h"
 #include "flutter/shell/platform/tizen/public/flutter_platform_view.h"
 #include "flutter/shell/platform/tizen/tizen_log.h"
@@ -33,10 +32,8 @@ bool GetValueFromEncodableMap(const EncodableValue& arguments,
   return false;
 }
 
-PlatformViewChannel::PlatformViewChannel(BinaryMessenger* messenger,
-                                         FlutterTizenEngine* engine)
-    : engine_(engine),
-      channel_(std::make_unique<MethodChannel<EncodableValue>>(
+PlatformViewChannel::PlatformViewChannel(BinaryMessenger* messenger)
+    : channel_(std::make_unique<MethodChannel<EncodableValue>>(
           messenger,
           kChannelName,
           &StandardMethodCodec::GetInstance())) {
@@ -95,23 +92,6 @@ void PlatformViewChannel::SendKeyEvent(Ecore_Event_Key* key, bool is_down) {
   }
 }
 
-void PlatformViewChannel::DispatchCompositionUpdateEvent(
-    const std::string& key) {
-  auto instances = ViewInstances();
-  auto it = instances.find(CurrentFocusedViewId());
-  if (it != instances.end()) {
-    it->second->DispatchCompositionUpdateEvent(key.c_str(), key.size());
-  }
-}
-
-void PlatformViewChannel::DispatchCompositionEndEvent(const std::string& key) {
-  auto instances = ViewInstances();
-  auto it = instances.find(CurrentFocusedViewId());
-  if (it != instances.end()) {
-    it->second->DispatchCompositionEndEvent(key.c_str(), key.size());
-  }
-}
-
 int PlatformViewChannel::CurrentFocusedViewId() {
   for (auto it = view_instances_.begin(); it != view_instances_.end(); it++) {
     if (it->second->IsFocused()) {
@@ -162,12 +142,6 @@ void PlatformViewChannel::HandleMethodCall(
       if (view_instance) {
         view_instances_.insert(
             std::pair<int, PlatformView*>(view_id, view_instance));
-
-        if (engine_ && engine_->text_input_channel) {
-          Ecore_IMF_Context* context =
-              engine_->text_input_channel->GetImfContext();
-          view_instance->SetSoftwareKeyboardContext(context);
-        }
         result->Success(EncodableValue(view_instance->GetTextureId()));
       } else {
         result->Error("Can't create a webview instance!!");
@@ -264,5 +238,4 @@ void PlatformViewChannel::HandleMethodCall(
     }
   }
 }
-
 }  // namespace flutter

shell/platform/tizen/channels/platform_view_channel.h

@@ -20,12 +20,9 @@ class PlatformViewFactory;
 
 namespace flutter {
 
-class FlutterTizenEngine;
-
 class PlatformViewChannel {
  public:
-  explicit PlatformViewChannel(BinaryMessenger* messenger,
-                               FlutterTizenEngine* engine);
+  explicit PlatformViewChannel(BinaryMessenger* messenger);
   virtual ~PlatformViewChannel();
 
   void Dispose();
@@ -41,14 +38,10 @@ class PlatformViewChannel {
   void SendKeyEvent(Ecore_Event_Key* key, bool is_down);
   int CurrentFocusedViewId();
 
-  void DispatchCompositionUpdateEvent(const std::string& key);
-  void DispatchCompositionEndEvent(const std::string& key);
-
  private:
   void HandleMethodCall(const MethodCall<EncodableValue>& call,
                         std::unique_ptr<MethodResult<EncodableValue>> result);
 
-  FlutterTizenEngine* engine_;
   std::unique_ptr<MethodChannel<EncodableValue>> channel_;
   std::map<std::string, std::unique_ptr<PlatformViewFactory>> view_factories_;
   std::map<int, PlatformView*> view_instances_;