Skip to content

Commit 303b86f

Browse files
authored
Counts go_router and go_router_builder custom test folders as tests (#2973)
related flutter/packages#4627
1 parent e09dba1 commit 303b86f

File tree

2 files changed

+68
-1
lines changed

2 files changed

+68
-1
lines changed

app_dart/lib/src/request_handlers/github/webhook_subscription.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,10 @@ class GithubWebhookSubscription extends SubscriptionHandler {
441441
// Native Windows tests.
442442
filename.endsWith('_test.cpp') ||
443443
// Pigeon native tests.
444-
filename.contains('/platform_tests/')) {
444+
filename.contains('/platform_tests/') ||
445+
// Test files in package-specific test folders.
446+
filename.contains('go_router/test_fixes/') ||
447+
filename.contains('go_router_builder/test_inputs/')) {
445448
hasTests = true;
446449
}
447450
}

app_dart/test/request_handlers/github/webhook_subscription_test.dart

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,13 +1692,15 @@ void foo() {
16921692
),
16931693
);
16941694
});
1695+
16951696
test('Packages does not comment if Pigeon native tests', () async {
16961697
const int issueNumber = 123;
16971698

16981699
tester.message = generateGithubWebhookMessage(
16991700
action: 'opened',
17001701
number: issueNumber,
17011702
slug: Config.packagesSlug,
1703+
baseRef: Config.defaultBranch(Config.packagesSlug),
17021704
);
17031705
when(pullRequestsService.listFiles(Config.packagesSlug, issueNumber)).thenAnswer(
17041706
(_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
@@ -1719,6 +1721,68 @@ void foo() {
17191721
);
17201722
});
17211723

1724+
test('Packages does not comment if editing test files in go_router', () async {
1725+
const int issueNumber = 123;
1726+
1727+
tester.message = generateGithubWebhookMessage(
1728+
action: 'opened',
1729+
number: issueNumber,
1730+
slug: Config.packagesSlug,
1731+
baseRef: Config.defaultBranch(Config.packagesSlug),
1732+
);
1733+
when(pullRequestsService.listFiles(Config.packagesSlug, issueNumber)).thenAnswer(
1734+
(_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
1735+
PullRequestFile()
1736+
..filename = 'packages/packages/go_router/test_fixes/go_router.dart'
1737+
..additionsCount = 10,
1738+
PullRequestFile()
1739+
..filename = 'packages/packages/go_router/lib/fix_data.yaml'
1740+
..additionsCount = 10,
1741+
]),
1742+
);
1743+
1744+
await tester.post(webhook);
1745+
1746+
verifyNever(
1747+
issuesService.createComment(
1748+
Config.packagesSlug,
1749+
issueNumber,
1750+
argThat(contains(config.missingTestsPullRequestMessageValue)),
1751+
),
1752+
);
1753+
});
1754+
1755+
test('Packages does not comment if editing test files in go_router_builder', () async {
1756+
const int issueNumber = 123;
1757+
1758+
tester.message = generateGithubWebhookMessage(
1759+
action: 'opened',
1760+
number: issueNumber,
1761+
slug: Config.packagesSlug,
1762+
baseRef: Config.defaultBranch(Config.packagesSlug),
1763+
);
1764+
when(pullRequestsService.listFiles(Config.packagesSlug, issueNumber)).thenAnswer(
1765+
(_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
1766+
PullRequestFile()
1767+
..filename = 'packages/packages/go_router_builder/lib/src/route_config.dart'
1768+
..additionsCount = 10,
1769+
PullRequestFile()
1770+
..filename = 'packages/packages/go_router_builder/test_inputs/bad_path_pattern.dart'
1771+
..additionsCount = 10,
1772+
]),
1773+
);
1774+
1775+
await tester.post(webhook);
1776+
1777+
verifyNever(
1778+
issuesService.createComment(
1779+
Config.packagesSlug,
1780+
issueNumber,
1781+
argThat(contains(config.missingTestsPullRequestMessageValue)),
1782+
),
1783+
);
1784+
});
1785+
17221786
test('Packages comments and labels if no tests', () async {
17231787
const int issueNumber = 123;
17241788

0 commit comments

Comments
 (0)