Skip to content

Commit 48875a0

Browse files
authored
[dashboard] Fix Log-In button not showing up. (#3443)
Cocoon's dependabot seems to be ignoring "patch" (`+z`) releases in packages with version < `1.0.0`. That's caused them to miss [a fix in how the Google Sign In button renders into the app](flutter/packages#5660) that was released as a "patch" version (`0.12.3+1`). This PR updates the cocoon dependency to the fixed version of the package, so the Google Sign In button renders normally again. (It also uses a new API introduced in 0.12.3 to access `web_only` components much more easily than before, which allows to remove an intermediate dependency). ## Issues * Fixes flutter/flutter#142195
1 parent a22d1ad commit 48875a0

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

dashboard/lib/widgets/sign_in_button/sign_in_button_web.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,14 @@
33
// found in the LICENSE file.
44

55
import 'package:flutter/material.dart';
6-
7-
import 'package:google_sign_in_platform_interface/google_sign_in_platform_interface.dart';
8-
import 'package:google_sign_in_web/google_sign_in_web.dart';
6+
import 'package:google_sign_in_web/web_only.dart' as gsi_web;
97

108
/// Widget that users can click to initiate the Sign In process.
119
class SignInButton extends StatelessWidget {
1210
const SignInButton({super.key});
1311

1412
@override
1513
Widget build(BuildContext context) {
16-
return (GoogleSignInPlatform.instance as GoogleSignInPlugin).renderButton();
14+
return gsi_web.renderButton();
1715
}
1816
}

dashboard/pubspec.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ dependencies:
1919
fixnum: 1.1.0 # Rolled by dependabot
2020
flutter_app_icons: 0.0.9 # Rolled by dependabot
2121
google_sign_in: 6.2.1 # Rolled by dependabot
22-
google_sign_in_platform_interface: any # Match google_sign_in
23-
google_sign_in_web: 0.12.3 # Rolled by dependabot
22+
google_sign_in_web: 0.12.3+2 # Rolled by dependabot
2423
http: 1.2.0 # Rolled by dependabot
2524
protobuf: 3.1.0 # Rolled by dependabot
2625
provider: 6.1.1 # Rolled by dependabot

0 commit comments

Comments
 (0)