Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the value of the evalHistory field of the DebuggerController provider triggers exceptions #2997

Closed
jacob314 opened this issue May 8, 2021 · 2 comments

Comments

@jacob314
Copy link
Contributor

jacob314 commented May 8, 2021

Repro:
Run a flutter app.
Run devtools in flutter desktop debug mode and attach it to that flutter app
Attach devtools in flutter desktop profile to that devtools in debug mode app

Go to the debugger page in the debug mode desktop
pause at a breakpoint and eval a few expressions

Open the provider tab of the profile mode devtools
open eval history in the debugger provider
edit the value.

Error in console:

flutter: [ERROR]: Provider AutoDisposeStateNotifierProvider<StateController<AsyncValue<InstanceDetails>>, AsyncValue<InstanceDetails>>#00fca(name: familyDebounced(0:00:01.000000) (InstancePath.fromProviderId(providerId: 6, pathToProperty: [PathToProperty.objectProperty(name: _uriToScriptMap, ownerUri: package:devtools_app/src/debugger/debugger_controller.dart, ownerName: DebuggerController)])), from: Instance of 'AutoDisposeStateNotifierProviderFamily<StateController<AsyncValue<InstanceDetails>>, AsyncValue<InstanceDetails>, InstancePath>', argument: InstancePath.fromProviderId(providerId: 6, pathToProperty: [PathToProperty.objectProperty(name: _uriToScriptMap, ownerUri: package:devtools_app/src/debugger/debugger_controller.dart, ownerName: DebuggerController)])) failed with "Evaluation `value` failed with [ErrorRef id: objects/28983, kind: UnhandledException, message: Unhandled exception:
Stack Overflow
<Received error while converting stack trace to string>]"
flutter: #0      EvalOnDartLibrary.safeEval (package:devtools_app/src/eval_on_dart_library.dart:410)
<asynchronous suspension>
#1      rawInstanceProvider.<anonymous closure> (package:devtools_app/src/provider/instance_viewer/instance_providers.dart:280)
<asynchronous suspension>
#2      Future.wait.<anonymous closure> (dart:async/future.dart)
<asynchronous suspension>
#3      rawInstanceProvider.<anonymous closure> (package:devtools_app/src/provider/instance_viewer/instance_providers.dart:332)
<asynchronous suspension>
#4      _FutureProviderStateMixin.valueChanged.<anonymous closure> (package:riverpod/src/future_provider.dart)
<asynchronous suspension>

The value of the field in the _evalHistory shows as an error but works if you close and open _evalHistory again.

Screen Shot 2021-05-07 at 5 07 38 PM
Screen Shot 2021-05-07 at 5 08 46 PM

@rrousselGit
Copy link
Contributor

I have tried a few times, but I am unable to reproduce the issue.

Do you think you could share a video of the process? Maybe I am not correctly following the steps.

@elliette
Copy link
Member

Now that the Provider panel is a DevTools extension, I'm closing this issue in favor of rrousselGit/provider#883.

@elliette elliette closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants