fuchsia: Fix multi-views fallout

Author: arbreng

flow/view_holder.cc

@@ -74,7 +74,7 @@ void ViewHolder::Destroy(zx_koid_t id, ViewIdCallback on_view_destroyed) {
   auto binding = bindings->find(id);
   FML_DCHECK(binding != bindings->end());
 
-  if (binding->second->view_holder_) {
+  if (binding->second->view_holder_ && on_view_destroyed) {
     on_view_destroyed(binding->second->view_holder_->id());
   }
   bindings->erase(id);

shell/platform/fuchsia/flutter/platform_view.cc

@@ -483,13 +483,14 @@ bool PlatformView::OnChildViewStateChanged(scenic::ResourceId view_holder_id,
     return false;
   }
 
+  const std::string is_rendering_str = state ? "true" : "false";
   std::ostringstream out;
   out << "{"
       << "\"method\":\"View.viewStateChanged\","
       << "\"args\":{"
       << "  \"viewId\":" << view_id_mapping->second << ","  // ViewHolderToken
-      << "  \"is_rendering\":" << is_rendering << ","       // IsViewRendering
-      << "  \"state\":" << is_rendering                     // IsViewRendering
+      << "  \"is_rendering\":" << is_rendering_str << ","   // IsViewRendering
+      << "  \"state\":" << is_rendering_str                 // IsViewRendering
       << "  }"
       << "}";
   auto call = out.str();

shell/platform/fuchsia/flutter/platform_view_unittest.cc

@@ -877,9 +877,9 @@ TEST_F(PlatformViewTests, ViewEventsTest) {
       << "{"
       << "\"method\":\"View.viewStateChanged\","
       << "\"args\":{"
-      << "  \"viewId\":" << kViewId << ","     // ViewHolderToken
-      << "  \"is_rendering\":" << true << ","  // IsViewRendering
-      << "  \"state\":" << true                // IsViewRendering
+      << "  \"viewId\":" << kViewId << ","  // ViewHolderToken
+      << "  \"is_rendering\":true,"         // IsViewRendering
+      << "  \"state\":true"                 // IsViewRendering
       << "  }"
       << "}";
   EXPECT_EQ(view_state_changed_expected_out.str(),