update comment

gaaclarke · gaaclarke · commit 07935acd39cf · 2023-05-01T11:53:40.000-07:00
diff --git a/impeller/renderer/backend/vulkan/context_vk.cc b/impeller/renderer/backend/vulkan/context_vk.cc
@@ -111,8 +111,9 @@ ContextVK::~ContextVK() {
     [[maybe_unused]] auto result = device_->waitIdle();
   }
   CommandPoolVK::ClearAllPools(this);
-  // Shut down the worker message loop before the context starts getting torn
-  // down.
+  // Delete `worker_message_loop_` to ensure that ~ConcurrentMessageLoop() is
+  // executed before the instance variables are deleted. This will synchronize
+  // on joining ConcurrentMessageLoop's threads.
   worker_message_loop_.reset();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,9 @@ ContextVK::~ContextVK() {`
`111`	`111`	`[[maybe_unused]] auto result = device_->waitIdle();`
`112`	`112`	`}`
`113`	`113`	`CommandPoolVK::ClearAllPools(this);`
`114`		`- // Shut down the worker message loop before the context starts getting torn`
`115`		`- // down.`
	`114`	+ // Delete `worker_message_loop_` to ensure that ~ConcurrentMessageLoop() is
	`115`	`+ // executed before the instance variables are deleted. This will synchronize`
	`116`	`+ // on joining ConcurrentMessageLoop's threads.`
`116`	`117`	`worker_message_loop_.reset();`
`117`	`118`	`}`
`118`	`119`