Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 10f1586

Browse files
bwilkersoncommit-bot@chromium.org
authored andcommitted
Return the URL of recently published docs
Change-Id: Iea19a318182a5c8c3ad1368f9655cf6f5f304301 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126480 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
1 parent 61f5e88 commit 10f1586

File tree

4 files changed

+83
-42
lines changed

4 files changed

+83
-42
lines changed

pkg/analyzer/lib/src/dart/error/hint_codes.dart

Lines changed: 28 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ class HintCode extends AnalyzerErrorCode {
7474
// ```
7575
static const HintCode DEAD_CODE = const HintCode('DEAD_CODE', "Dead code.",
7676
correction: "Try removing the code, or "
77-
"fixing the code before it so that it can be reached.");
77+
"fixing the code before it so that it can be reached.",
78+
hasPublishedDocs: true);
7879

7980
/**
8081
* Dead code is code that is never reached. This case covers cases where the
@@ -132,7 +133,8 @@ class HintCode extends AnalyzerErrorCode {
132133
"'on Object catch (e)' are never reached.",
133134
correction:
134135
"Try reordering the catch clauses so that they can be reached, or "
135-
"removing the unreachable catch clauses.");
136+
"removing the unreachable catch clauses.",
137+
hasPublishedDocs: true);
136138

137139
/**
138140
* Dead code is code that is never reached. This case covers cases where the
@@ -194,7 +196,8 @@ class HintCode extends AnalyzerErrorCode {
194196
"subtype of '{1}' and hence will have been caught already.",
195197
correction:
196198
"Try reordering the catch clauses so that this block can be reached, "
197-
"or removing the unreachable catch clause.");
199+
"or removing the unreachable catch clause.",
200+
hasPublishedDocs: true);
198201

199202
/**
200203
* Users should not create a class named `Function` anymore.
@@ -348,7 +351,8 @@ class HintCode extends AnalyzerErrorCode {
348351
// ```
349352
static const HintCode DUPLICATE_IMPORT = const HintCode(
350353
'DUPLICATE_IMPORT', "Duplicate import.",
351-
correction: "Try removing all but one import of the library.");
354+
correction: "Try removing all but one import of the library.",
355+
hasPublishedDocs: true);
352356

353357
/**
354358
* Duplicate hidden names.
@@ -740,7 +744,8 @@ class HintCode extends AnalyzerErrorCode {
740744
static const HintCode INVALID_VISIBILITY_ANNOTATION = const HintCode(
741745
'INVALID_VISIBILITY_ANNOTATION',
742746
"The member '{0}' is annotated with '{1}', but this annotation is only "
743-
"meaningful on declarations of public members.");
747+
"meaningful on declarations of public members.",
748+
hasPublishedDocs: true);
744749

745750
/**
746751
* Hint for the `x is double` type checks.
@@ -834,7 +839,8 @@ class HintCode extends AnalyzerErrorCode {
834839
// }
835840
// ```
836841
static const HintCode MISSING_REQUIRED_PARAM = const HintCode(
837-
'MISSING_REQUIRED_PARAM', "The parameter '{0}' is required.");
842+
'MISSING_REQUIRED_PARAM', "The parameter '{0}' is required.",
843+
hasPublishedDocs: true);
838844

839845
/**
840846
* Generate a hint for a constructor, function or method invocation where a
@@ -848,7 +854,8 @@ class HintCode extends AnalyzerErrorCode {
848854
const HintCodeWithUniqueName(
849855
'MISSING_REQUIRED_PARAM',
850856
'HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS',
851-
"The parameter '{0}' is required. {1}.");
857+
"The parameter '{0}' is required. {1}.",
858+
hasPublishedDocs: true);
852859

853860
/**
854861
* Parameters:
@@ -932,7 +939,8 @@ class HintCode extends AnalyzerErrorCode {
932939
"superclass.",
933940
correction:
934941
"Try composing with this class, or refer to its documentation for "
935-
"more information.");
942+
"more information.",
943+
hasPublishedDocs: true);
936944

937945
/**
938946
* Generate a hint for classes that inherit from classes annotated with
@@ -1004,7 +1012,8 @@ class HintCode extends AnalyzerErrorCode {
10041012
'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR',
10051013
"This instance creation must be 'const', because the {0} constructor is "
10061014
"marked as '@literal'.",
1007-
correction: "Try adding a 'const' keyword.");
1015+
correction: "Try adding a 'const' keyword.",
1016+
hasPublishedDocs: true);
10081017

10091018
/**
10101019
* Generate a hint for non-const instance creation (with the `new` keyword)
@@ -1019,7 +1028,8 @@ class HintCode extends AnalyzerErrorCode {
10191028
'HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW',
10201029
"This instance creation must be 'const', because the {0} constructor "
10211030
"is marked as '@literal'.",
1022-
correction: "Try replacing the 'new' keyword with 'const'.");
1031+
correction: "Try replacing the 'new' keyword with 'const'.",
1032+
hasPublishedDocs: true);
10231033

10241034
/**
10251035
* When the left operand of a binary expression uses '?.' operator, it can be
@@ -1074,7 +1084,8 @@ class HintCode extends AnalyzerErrorCode {
10741084
'HintCode.OVERRIDE_ON_NON_OVERRIDING_GETTER',
10751085
"The getter doesn't override an inherited getter.",
10761086
correction: "Try updating this class to match the superclass, or "
1077-
"removing the override annotation.");
1087+
"removing the override annotation.",
1088+
hasPublishedDocs: true);
10781089

10791090
/**
10801091
* A field with the override annotation does not override a getter or setter.
@@ -1087,7 +1098,8 @@ class HintCode extends AnalyzerErrorCode {
10871098
'HintCode.OVERRIDE_ON_NON_OVERRIDING_FIELD',
10881099
"The field doesn't override an inherited getter or setter.",
10891100
correction: "Try updating this class to match the superclass, or "
1090-
"removing the override annotation.");
1101+
"removing the override annotation.",
1102+
hasPublishedDocs: true);
10911103

10921104
/**
10931105
* A method with the override annotation does not override an existing method.
@@ -1134,7 +1146,8 @@ class HintCode extends AnalyzerErrorCode {
11341146
'HintCode.OVERRIDE_ON_NON_OVERRIDING_METHOD',
11351147
"The method doesn't override an inherited method.",
11361148
correction: "Try updating this class to match the superclass, or "
1137-
"removing the override annotation.");
1149+
"removing the override annotation.",
1150+
hasPublishedDocs: true);
11381151

11391152
/**
11401153
* A setter with the override annotation does not override an existing setter.
@@ -1147,7 +1160,8 @@ class HintCode extends AnalyzerErrorCode {
11471160
'HintCode.OVERRIDE_ON_NON_OVERRIDING_SETTER',
11481161
"The setter doesn't override an inherited setter.",
11491162
correction: "Try updating this class to match the superclass, or "
1150-
"removing the override annotation.");
1163+
"removing the override annotation.",
1164+
hasPublishedDocs: true);
11511165

11521166
/**
11531167
* It is a bad practice for a package import to reference anything outside the

pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ const ParserErrorCode _INVALID_UNICODE_ESCAPE = const ParserErrorCode(
403403
const ParserErrorCode _INVALID_USE_OF_COVARIANT_IN_EXTENSION =
404404
const ParserErrorCode('INVALID_USE_OF_COVARIANT_IN_EXTENSION',
405405
r"Can't have modifier '#lexeme' in an extension.",
406-
correction: "Try removing '#lexeme'.");
406+
correction: "Try removing '#lexeme'.", hasPublishedDocs: true);
407407

408408
const ParserErrorCode _LIBRARY_DIRECTIVE_NOT_FIRST = const ParserErrorCode(
409409
'LIBRARY_DIRECTIVE_NOT_FIRST',

0 commit comments

Comments
 (0)