Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 188bff5

Browse files
committed
added dart plugin registrant test executables to run_tests.py
1 parent e97c801 commit 188bff5

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

runtime/dart_isolate.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,8 @@ bool EndsWith(const std::string& str, const std::string& ending) {
720720
}
721721

722722
Dart_Handle FindDartPluginRegistrantLibrary() {
723-
// TODO(): Instead of finding this, it could be passed down from the tool.
723+
// TODO(99308): Instead of finding this, it could be passed down from the
724+
// tool.
724725
Dart_Handle libraries = Dart_GetLoadedLibraries();
725726
intptr_t length = 0;
726727
Dart_ListLength(libraries, &length);

testing/run_tests.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,10 @@ def RunCCTests(build_dir, filter, coverage, capture_core_dump):
202202

203203
RunEngineExecutable(build_dir, 'tonic_unittests', filter, shuffle_flags, coverage=coverage)
204204

205+
RunEngineExecutable(build_dir, 'no_dart_plugin_registrant_unittests', filter, shuffle_flags, coverage=coverage)
206+
207+
RunEngineExecutable(build_dir, 'dart_plugin_registrant_unittests', filter, shuffle_flags, coverage=coverage)
208+
205209
if not IsWindows():
206210
# https://github.com/flutter/flutter/issues/36295
207211
RunEngineExecutable(build_dir, 'shell_unittests', filter, shuffle_flags, coverage=coverage)

0 commit comments

Comments
 (0)