Fix some function naming style issues.

Author: flar

flow/layers/container_layer.cc

@@ -16,11 +16,11 @@ void ContainerLayer::Add(std::shared_ptr<Layer> layer) {
   the_layer->set_parent(this);
   layers_.push_back(std::move(layer));
   if (the_layer->tree_reads_surface()) {
-    update_child_readback(the_layer);
+    UpdateChildReadback(the_layer);
   }
 }
 
-void ContainerLayer::update_child_readback(Layer* layer) {
+void ContainerLayer::UpdateChildReadback(Layer* layer) {
   if (child_needs_screen_readback_ == layer->tree_reads_surface()) {
     return;
   }
@@ -36,10 +36,10 @@ void ContainerLayer::update_child_readback(Layer* layer) {
   } else {
     child_needs_screen_readback_ = true;
   }
-  update_screen_readback();
+  UpdateTreeReadsSurface();
 }
 
-bool ContainerLayer::compute_tree_reads_surface() {
+bool ContainerLayer::ComputeTreeReadsSurface() {
   return layer_reads_surface() ||
          (!renders_to_save_layer_ && child_needs_screen_readback_);
 }

flow/layers/container_layer.h

@@ -27,15 +27,15 @@ class ContainerLayer : public Layer {
 
   // Called when the layer, which must be a child of this container,
   // changes its tree_reads_surface() result.
-  void update_child_readback(Layer* layer);
+  void UpdateChildReadback(Layer* layer);
 
  protected:
   void PrerollChildren(PrerollContext* context,
                        const SkMatrix& child_matrix,
                        SkRect* child_paint_bounds);
   void PaintChildren(PaintContext& context) const;
 
-  virtual bool compute_tree_reads_surface() override;
+  virtual bool ComputeTreeReadsSurface() override;
 
 #if defined(OS_FUCHSIA)
   void UpdateSceneChildren(SceneUpdateContext& context);
@@ -51,7 +51,7 @@ class ContainerLayer : public Layer {
   void set_renders_to_save_layer(bool protects) {
     if (renders_to_save_layer_ != protects) {
       renders_to_save_layer_ = protects;
-      update_screen_readback();
+      UpdateTreeReadsSurface();
     }
   }
 
@@ -60,7 +60,7 @@ class ContainerLayer : public Layer {
     layers_.clear();
     if (child_needs_screen_readback_) {
       child_needs_screen_readback_ = false;
-      update_screen_readback();
+      UpdateTreeReadsSurface();
     }
   }
 

flow/layers/layer.cc

@@ -29,17 +29,17 @@ uint64_t Layer::NextUniqueID() {
   return id;
 }
 
-bool Layer::compute_tree_reads_surface() {
+bool Layer::ComputeTreeReadsSurface() {
   return layer_reads_surface_;
 }
 
-void Layer::update_screen_readback() {
-  bool new_tree_reads_surface = compute_tree_reads_surface();
+void Layer::UpdateTreeReadsSurface() {
+  bool new_tree_reads_surface = ComputeTreeReadsSurface();
 
   if (tree_reads_surface_ != new_tree_reads_surface) {
     tree_reads_surface_ = new_tree_reads_surface;
     if (parent_ != nullptr) {
-      parent_->update_child_readback(this);
+      parent_->UpdateChildReadback(this);
     }
   }
 }

flow/layers/layer.h

@@ -147,22 +147,26 @@ class Layer {
 
   // True iff the layer, or some descendant of the layer, performs an
   // operation which depends on (i.e. must read back from) the surface
-  // on which it is rendered. This value has no setter as it is computed
-  // from other flags and properties on the layer.
-  // see Layer::update_screen_readback()
+  // on which it is rendered in any way beyond the functionality of
+  // BlendMode. This value has no setter as it is computed from other
+  // flags and properties on the layer.
+  //
+  // see Layer::UpdateTreeReadsSurface()
   // see Layer::set_layer_reads_surface()
   // see ContainerLayer::set_renders_to_save_layer()
-  // see ContainerLayer::update_child_readback()
+  // see ContainerLayer::UpdateChildReadback()
   bool tree_reads_surface() { return tree_reads_surface_; }
 
   uint64_t unique_id() const { return unique_id_; }
 
  protected:
-  virtual bool compute_tree_reads_surface();
+  // Compute a new value for tree_reads_surface_ from all of the various
+  // properties of this layer.
+  virtual bool ComputeTreeReadsSurface();
 
-  // Compute a new value for tree_reads_surface_ and propagate it to
-  // ancestors if it changes.
-  void update_screen_readback();
+  // Update the tree_reads_surface_ value and propagate changes to
+  // ancestors if needed.
+  void UpdateTreeReadsSurface();
 
   // True iff the layer itself (not a child or other descendant) performs
   // an operation which must read back from the surface on which it is
@@ -172,7 +176,7 @@ class Layer {
   void set_layer_reads_surface(bool reads) {
     if (layer_reads_surface_ != reads) {
       layer_reads_surface_ = reads;
-      update_screen_readback();
+      UpdateTreeReadsSurface();
     }
   }