[Impeller] Turned on swiftshader for golden image tests

Author: gaaclarke

impeller/golden_tests/BUILD.gn

@@ -75,5 +75,9 @@ if (is_mac) {
       "//flutter/impeller/fixtures",
       "//third_party/googletest:gtest",
     ]
+
+    if (impeller_enable_vulkan) {
+      deps += [ "//third_party/swiftshader" ]
+    }
   }
 }

impeller/golden_tests/golden_playground_test.h

@@ -24,6 +24,8 @@ class GoldenPlaygroundTest
 
   void SetUp();
 
+  void TearDown();
+
   PlaygroundBackend GetBackend() const;
 
   bool OpenPlaygroundHere(const Picture& picture);

impeller/golden_tests/golden_playground_test_mac.cc

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <dlfcn.h>
+#include <filesystem>
+
 #include "flutter/impeller/golden_tests/golden_playground_test.h"
 
 #include "flutter/impeller/aiks/picture.h"
@@ -14,18 +17,30 @@ namespace impeller {
 // to also be a golden test, then add the test name here.
 static const std::vector<std::string> kSkipTests = {
     "impeller_Play_AiksTest_CanRenderLinearGradientManyColorsUnevenStops_Metal",
+    "impeller_Play_AiksTest_CanRenderLinearGradientManyColorsUnevenStops_"
+    "Vulkan",
     "impeller_Play_AiksTest_CanRenderRadialGradient_Metal",
+    "impeller_Play_AiksTest_CanRenderRadialGradient_Vulkan",
     "impeller_Play_AiksTest_CanRenderRadialGradientManyColors_Metal",
+    "impeller_Play_AiksTest_CanRenderRadialGradientManyColors_Vulkan",
     "impeller_Play_AiksTest_TextFrameSubpixelAlignment_Metal",
+    "impeller_Play_AiksTest_TextFrameSubpixelAlignment_Vulkan",
     "impeller_Play_AiksTest_ColorWheel_Metal",
+    "impeller_Play_AiksTest_ColorWheel_Vulkan",
     "impeller_Play_AiksTest_SolidStrokesRenderCorrectly_Metal",
+    "impeller_Play_AiksTest_SolidStrokesRenderCorrectly_Vulkan",
     "impeller_Play_AiksTest_GradientStrokesRenderCorrectly_Metal",
+    "impeller_Play_AiksTest_GradientStrokesRenderCorrectly_Vulkan",
     "impeller_Play_AiksTest_CoverageOriginShouldBeAccountedForInSubpasses_"
     "Metal",
+    "impeller_Play_AiksTest_CoverageOriginShouldBeAccountedForInSubpasses_"
+    "Vulkan",
     "impeller_Play_AiksTest_SceneColorSource_Metal",
+    "impeller_Play_AiksTest_SceneColorSource_Vulkan",
     // TextRotated is flakey and we can't seem to get it to stabilize on Skia
     // Gold.
     "impeller_Play_AiksTest_TextRotated_Metal",
+    "impeller_Play_AiksTest_TextRotated_Vulkan",
 };
 
 namespace {
@@ -68,8 +83,22 @@ struct GoldenPlaygroundTest::GoldenPlaygroundTestImpl {
 GoldenPlaygroundTest::GoldenPlaygroundTest()
     : pimpl_(new GoldenPlaygroundTest::GoldenPlaygroundTestImpl()) {}
 
+void GoldenPlaygroundTest::TearDown() {
+  ASSERT_FALSE(dlopen("/usr/local/lib/libMoltenVK.dylib", RTLD_NOLOAD));
+}
+
 void GoldenPlaygroundTest::SetUp() {
-  if (GetBackend() != PlaygroundBackend::kMetal) {
+  std::filesystem::path testing_assets_path =
+      flutter::testing::GetTestingAssetsPath();
+  std::filesystem::path target_path = testing_assets_path.parent_path()
+                                          .parent_path()
+                                          .parent_path()
+                                          .parent_path();
+  std::filesystem::path icd_path = target_path / "vk_swiftshader_icd.json";
+  setenv("VK_ICD_FILENAMES", icd_path.c_str(), 1);
+
+  if (GetBackend() != PlaygroundBackend::kMetal &&
+      GetBackend() != PlaygroundBackend::kVulkan) {
     GTEST_SKIP_("GoldenPlaygroundTest doesn't support this backend type.");
     return;
   }

impeller/golden_tests/golden_playground_test_stub.cc

@@ -8,6 +8,8 @@ namespace impeller {
 
 GoldenPlaygroundTest::GoldenPlaygroundTest() {}
 
+void GoldenPlaygroundTest::TearDown() {}
+
 void GoldenPlaygroundTest::SetUp() {
   GTEST_SKIP_("GoldenPlaygroundTest doesn't support this backend type.");
 }

impeller/golden_tests/main.cc

@@ -57,5 +57,6 @@ int main(int argc, char** argv) {
     impeller::testing::GoldenDigest::Instance()->Write(
         impeller::testing::WorkingDirectory::Instance());
   }
+
   return return_code;
 }

impeller/renderer/backend/vulkan/context_vk.cc

@@ -169,6 +169,7 @@ void ContextVK::Setup(Settings settings) {
   application_info.setPApplicationName("Impeller");
 
   std::vector<vk::ValidationFeatureEnableEXT> enabled_validations = {
+      vk::ValidationFeatureEnableEXT::eBestPractices,
       vk::ValidationFeatureEnableEXT::eSynchronizationValidation,
   };