Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 4bc9341

Browse files
authored
Revert "[web] Add js_types sources to build. (#40597)" (#40685)
This reverts commit 50f8374.
1 parent cc06014 commit 4bc9341

File tree

2 files changed

+0
-25
lines changed

2 files changed

+0
-25
lines changed

sky/packages/sky_engine/BUILD.gn

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import("//flutter/lib/ui/dart_ui.gni")
88
import("//third_party/dart/sdk/lib/_http/http_sources.gni")
99
import(
1010
"//third_party/dart/sdk/lib/_internal/js_runtime/interceptors_sources.gni")
11-
import("//third_party/dart/sdk/lib/_internal/js_shared/js_types_sources.gni")
1211
import("//third_party/dart/sdk/lib/async/async_sources.gni")
1312
import("//third_party/dart/sdk/lib/collection/collection_sources.gni")
1413
import("//third_party/dart/sdk/lib/convert/convert_sources.gni")
@@ -19,7 +18,6 @@ import("//third_party/dart/sdk/lib/html/html_sources.gni")
1918
import("//third_party/dart/sdk/lib/internal/internal_sources.gni")
2019
import("//third_party/dart/sdk/lib/io/io_sources.gni")
2120
import("//third_party/dart/sdk/lib/isolate/isolate_sources.gni")
22-
import("//third_party/dart/sdk/lib/js/js_annotations_sources.gni")
2321
import("//third_party/dart/sdk/lib/js/js_sources.gni")
2422
import("//third_party/dart/sdk/lib/js_interop/js_interop_sources.gni")
2523
import("//third_party/dart/sdk/lib/js_util/js_util_sources.gni")
@@ -88,19 +86,6 @@ copy("_interceptors") {
8886
]
8987
}
9088

91-
copy("_js_annotations") {
92-
lib_path = rebase_path("js", "", dart_sdk_lib_path)
93-
sources = rebase_path(js_annotations_sdk_sources, "", lib_path)
94-
outputs = [ "$root_gen_dir/dart-pkg/sky_engine/lib/_js_annotations/{{source_file_part}}" ]
95-
}
96-
97-
copy("_js_types") {
98-
lib_path = rebase_path("_internal/js_shared", "", dart_sdk_lib_path)
99-
sources = rebase_path(js_types_sdk_sources, "", lib_path)
100-
outputs =
101-
[ "$root_gen_dir/dart-pkg/sky_engine/lib/_js_types/{{source_file_part}}" ]
102-
}
103-
10489
copy("internal") {
10590
lib_path = rebase_path("internal", "", dart_sdk_lib_path)
10691
sources = rebase_path(internal_sdk_sources, "", lib_path)
@@ -195,8 +180,6 @@ group("copy_dart_sdk") {
195180
deps = [
196181
":_http",
197182
":_interceptors",
198-
":_js_annotations",
199-
":_js_types",
200183
":async",
201184
":collection",
202185
":convert",
@@ -247,10 +230,6 @@ generated_file("_embedder_yaml") {
247230
" # public API, e.g. List being Iterable by virtue of implementing",
248231
" # EfficientLengthIterable. Not including this library yields analysis errors.",
249232
" \"dart:_internal\": \"internal/internal.dart\"",
250-
" # The _js_annotations library is also needed for the same reasons as _internal.",
251-
" \"dart:_js_annotations\": \"_js_annotations/_js_annotations.dart\"",
252-
" # The _js_types library is also needed for the same reasons as _internal.",
253-
" \"dart:_js_types\": \"_js_types/js_types.dart\"",
254233
" \"dart:nativewrappers\": \"_empty.dart\"",
255234
]
256235
}

sky/packages/sky_engine/lib/_embedder.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,4 @@ embedded_libs:
2525
# public API, e.g. List being Iterable by virtue of implementing
2626
# EfficientLengthIterable. Not including this library yields analysis errors.
2727
"dart:_internal": "../../../../../third_party/dart/sdk/lib/internal/internal.dart"
28-
# The _js_annotations library is also needed for the same reasons as _internal.
29-
"dart:_js_annotations": "../../../../../third_party/dart/sdk/lib/js/_js_annotations.dart"
30-
# The _js_types library is also needed for the same reasons as _internal.
31-
"dart:_js_types": "../../../../../third_party/dart/sdk/lib/_internal/js_shared/lib/js_types.dart"
3228
"dart:nativewrappers": "_empty.dart"

0 commit comments

Comments
 (0)