Deprecated DartType.isObject

R=brianwilkerson@google.com

Change-Id: If588b23668764b07c99e327281bfeb11c8e31367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.39.9-dev
+* Deprecated `DartType.isObject`, use `DartType.isDartCoreObject` for
+  consistency with other similar getters.
+
 ## 0.39.8
 * Deprecated `VariableElement.constantValue`, it does not guarantee that
   the value has been computed. Use `computeConstantValue()` instead.

pkg/analyzer/lib/dart/element/type.dart

@@ -104,6 +104,7 @@ abstract class DartType {
   bool get isDynamic;
 
   /// Return `true` if this type represents the type 'Object'.
+  @Deprecated('Use isDartCoreObject')
   bool get isObject;
 
   /// Return `true` if this type represents the type 'void'.

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -356,7 +356,7 @@ class ConstantEvaluationEngine {
           // manually insert a reference to the implicit superconstructor.
           InterfaceType superclass =
               (constant.returnType as InterfaceType).superclass;
-          if (superclass != null && !superclass.isObject) {
+          if (superclass != null && !superclass.isDartCoreObject) {
             ConstructorElement unnamedConstructor =
                 superclass.element.unnamedConstructor?.declaration;
             if (unnamedConstructor != null) {
@@ -736,7 +736,7 @@ class ConstantEvaluationEngine {
     }
     // Evaluate explicit or implicit call to super().
     InterfaceType superclass = definingClass.superclass;
-    if (superclass != null && !superclass.isObject) {
+    if (superclass != null && !superclass.isDartCoreObject) {
       ConstructorElement superConstructor =
           superclass.lookUpConstructor(superName, constructor.library);
       if (superConstructor != null) {

pkg/analyzer/lib/src/dart/element/element.dart

@@ -777,7 +777,7 @@ class ClassElementImpl extends AbstractClassElementImpl
     if (hasReferenceToSuper) {
       return false;
     }
-    if (!supertype.isObject) {
+    if (!supertype.isDartCoreObject) {
       return false;
     }
     for (ConstructorElement constructor in constructors) {

pkg/analyzer/lib/src/dart/element/generic_inferrer.dart

@@ -39,7 +39,7 @@ bool _isLegacyTop(DartType t, {@required bool orTrueTop}) {
     return _isLegacyTop((t as InterfaceType).typeArguments[0],
         orTrueTop: orTrueTop);
   }
-  if (t.isObject && t.nullabilitySuffix == NullabilitySuffix.none) {
+  if (t.isDartCoreObject && t.nullabilitySuffix == NullabilitySuffix.none) {
     return true;
   }
   return orTrueTop ? _isTop(t) : false;
@@ -50,7 +50,7 @@ bool _isTop(DartType t) {
     return _isTop((t as InterfaceType).typeArguments[0]);
   }
   return t.isDynamic ||
-      (t.isObject && t.nullabilitySuffix != NullabilitySuffix.none) ||
+      (t.isDartCoreObject && t.nullabilitySuffix != NullabilitySuffix.none) ||
       t.isVoid ||
       identical(t, UnknownInferredType.instance);
 }

pkg/analyzer/lib/src/dart/element/subtype.dart

@@ -445,12 +445,12 @@ class SubtypeHelper {
     // Note: we should never reach `_isInterfaceSubtypeOf` with `i2 == Object`,
     // because top types are eliminated before `isSubtypeOf` calls this.
     // TODO(scheglov) Replace with assert().
-    if (identical(subType, superType) || superType.isObject) {
+    if (identical(subType, superType) || superType.isDartCoreObject) {
       return true;
     }
 
     // Object cannot subtype anything but itself (handled above).
-    if (subType.isObject) {
+    if (subType.isDartCoreObject) {
       return false;
     }
 

pkg/analyzer/lib/src/dart/element/type.dart

@@ -416,7 +416,7 @@ class FunctionTypeImpl extends TypeImpl implements FunctionType {
     } else if (identical(t, other) ||
         other.isDynamic ||
         other.isDartCoreFunction ||
-        other.isObject) {
+        other.isDartCoreObject) {
       return true;
     } else if (other is! FunctionType) {
       return false;
@@ -830,6 +830,7 @@ class InterfaceTypeImpl extends TypeImpl implements InterfaceType {
     return element.name == "Symbol" && element.library.isDartCore;
   }
 
+  @Deprecated('Use isDartCoreObject')
   @override
   bool get isObject => element.supertype == null && !element.isMixin;
 
@@ -1837,6 +1838,7 @@ abstract class TypeImpl implements DartType {
   @override
   bool get isDynamic => false;
 
+  @Deprecated('Use isDartCoreObject')
   @override
   bool get isObject => false;
 

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -658,7 +658,7 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
         return true;
       }
       // `is Object` or `is! Object`
-      if (rhsType.isObject) {
+      if (rhsType.isDartCoreObject) {
         var nullability = rhsType.nullabilitySuffix;
         if (nullability == NullabilitySuffix.star ||
             nullability == NullabilitySuffix.question) {

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -1928,7 +1928,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void> {
     if (supertype == null) {
       return;
     }
-    if (supertype.isObject) {
+    if (supertype.isDartCoreObject) {
       return;
     }
     ConstructorElement unnamedConstructor =
@@ -3249,7 +3249,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void> {
       TypeName mixinName, ClassElement mixinElement) {
     InterfaceType mixinSupertype = mixinElement.supertype;
     if (mixinSupertype != null) {
-      if (!mixinSupertype.isObject ||
+      if (!mixinSupertype.isDartCoreObject ||
           !mixinElement.isMixinApplication && mixinElement.mixins.isNotEmpty) {
         _errorReporter.reportErrorForNode(
             CompileTimeErrorCode.MIXIN_INHERITS_FROM_NOT_OBJECT,

pkg/analyzer/test/src/dart/resolution/mixin_test.dart

@@ -144,7 +144,7 @@ mixin M {}
     expect(element.isEnum, isFalse);
     expect(element.isMixin, isTrue);
     expect(element.isMixinApplication, isFalse);
-    expect(interfaceTypeStar(element).isObject, isFalse);
+    expect(interfaceTypeStar(element).isDartCoreObject, isFalse);
     expect(element.isDartCoreObject, isFalse);
 
     assertElementTypes(element.superclassConstraints, [objectType]);