Enable bugprone-unchecked-optional-access, disable in files with warnings (#42359)

First part of flutter/flutter#127701

Author: zanderso

.ci.yaml

@@ -278,6 +278,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"
@@ -298,6 +299,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"
@@ -541,6 +543,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"
@@ -563,6 +566,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - .clang-tidy
       - tools/**
       - ci/**
       - "**.h"

.clang-tidy

@@ -2,6 +2,7 @@
 # Note: Some of the checks here are used as errors selectively, see
 # //ci/lint.sh
 Checks: "bugprone-use-after-move,\
+bugprone-unchecked-optional-access,\
 clang-analyzer-*,\
 clang-diagnostic-*,\
 darwin-*,\

flow/layers/clip_path_layer_unittests.cc

@@ -14,6 +14,9 @@
 #include "flutter/fml/macros.h"
 #include "gtest/gtest.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -569,3 +572,5 @@ TEST_F(ClipPathLayerTest, EmptyClipDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/clip_rect_layer_unittests.cc

@@ -12,6 +12,9 @@
 #include "flutter/flow/testing/mock_layer.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -545,3 +548,5 @@ TEST_F(ClipRectLayerTest, EmptyClipDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/clip_rrect_layer_unittests.cc

@@ -12,6 +12,9 @@
 #include "flutter/flow/testing/mock_layer.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -594,3 +597,5 @@ TEST_F(ClipRRectLayerTest, EmptyClipDoesNotCullPlatformView) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/color_filter_layer_unittests.cc

@@ -17,6 +17,9 @@
 #include "flutter/flow/testing/mock_layer.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -454,3 +457,5 @@ TEST_F(ColorFilterLayerTest, OpacityInheritance) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/container_layer_unittests.cc

@@ -13,6 +13,9 @@
 #include "gtest/gtest.h"
 #include "include/core/SkMatrix.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -762,3 +765,5 @@ TEST_F(ContainerLayerDiffTest, ReplaceLayer) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/display_list_layer_unittests.cc

@@ -11,6 +11,9 @@
 #include "flutter/flow/testing/diff_context_test.h"
 #include "flutter/fml/macros.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -570,3 +573,5 @@ TEST_F(DisplayListLayerTest, OverflowCachedDisplayListOpacityInheritance) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/display_list_raster_cache_item.cc

@@ -16,6 +16,9 @@
 #include "flutter/flow/raster_cache_util.h"
 #include "third_party/skia/include/gpu/GrDirectContext.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 
 static bool IsDisplayListWorthRasterizing(
@@ -170,3 +173,5 @@ bool DisplayListRasterCacheItem::TryToPrepareRasterCache(
       });
 }
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)

flow/layers/image_filter_layer_unittests.cc

@@ -15,6 +15,9 @@
 #include "include/core/SkPath.h"
 #include "third_party/skia/include/effects/SkImageFilters.h"
 
+// TODO(zanderso): https://github.com/flutter/flutter/issues/127701
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
+
 namespace flutter {
 namespace testing {
 
@@ -710,3 +713,5 @@ TEST_F(ImageFilterLayerDiffTest, ImageFilterLayerInflatestChildSize) {
 
 }  // namespace testing
 }  // namespace flutter
+
+// NOLINTEND(bugprone-unchecked-optional-access)