Version 2.18.0-167.0.dev

Merge commit '55a4649075343b7202b38fce41edeac3e84696ce' into 'dev'

Author: Dart CI

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

DEPS

@@ -77,7 +77,7 @@ vars = {
   # Revisions of /third_party/* dependencies.
   "args_rev": "862d929b980b993334974d38485a39d891d83918",
   "async_rev": "f3ed5f690e2ec9dbe1bfc5184705575b4f6480e5",
-  "bazel_worker_rev": "ceeba0982d4ff40d32371c9d35f3d2dc1868de20",
+  "bazel_worker_rev": "9710de6c9c70b1b583183db9d9721ba64e5a16fe",
   "benchmark_harness_rev": "0530da692a5d689f4b5450a7c8d1a8abe3e2d555",
   "boolean_selector_rev": "1d3565e2651d16566bb556955b96ea75018cbd0c",
   "boringssl_gen_rev": "ced85ef0a00bbca77ce5a91261a5f2ae61b1e62f",
@@ -89,7 +89,7 @@ vars = {
   "chrome_rev": "19997",
   "cli_util_rev": "b0adbba89442b2ea6fef39c7a82fe79cb31e1168",
   "clock_rev": "f594d86da123015186d5680b0d0e8255c52fc162",
-  "collection_rev": "e1407da23b9f17400b3a905aafe2b8fa10db3d86",
+  "collection_rev": "69766daafbaa8535d1343fb7cd87e713f57c107f",
   "convert_rev": "00b251529c074df394b3391c7e3eea3dd9e5778e",
   "crypto_rev": "4297d240b0e1e780ec0a9eab23eaf1ad491f3e68",
   "csslib_rev": "518761b166974537f334dbf264e7f56cb157a96a",
@@ -127,35 +127,35 @@ vars = {
   "markupsafe_rev": "8f45f5cfa0009d2a70589bcda0349b8cb2b72783",
   "matcher_rev": "12cdc5fbafd666ed908359ae215d5d0306087969",
   "mime_rev": "c2c5ffd594674f32dc277521369da1557a1622d3",
-  "mockito_rev": "1e977a727e82a2e1bdb49b79ef1dce0f23aa1faa",
+  "mockito_rev": "fcd6b285f7c4a631778890cf02b52a9a68171a71",
   "oauth2_rev": "199ebf15cbd5b07958438184f32e41c4447a57bf",
   "package_config_rev": "cff98c90acc457a3b0750f0a7da0e351a35e5d0c",
   "path_rev": "3d41ea582f5b0b18de3d90008809b877ff3f69bc",
   "ply_rev": "604b32590ffad5cbb82e4afef1d305512d06ae93",
   "pool_rev": "c40cc32eabecb9d60f1045d1403108d968805f9a",
   "protobuf_rev": "b149f801cf7a5e959cf1dbf72d61068ac275f24b",
   "pub_rev": "51435efcd574b7bc18d47a5dd620cb9759dea8f8",
-  "pub_semver_rev": "ea6c54019948dc03042c595ce9413e17aaf7aa38",
+  "pub_semver_rev": "5c0b4bfd5ca57fe16f1319c581dc8c882e9b8cb2",
   "root_certificates_rev": "692f6d6488af68e0121317a9c2c9eb393eb0ee50",
   "rust_revision": "b7856f695d65a8ebc846754f97d15814bcb1c244",
   "shelf_rev": "05f42601d22c9bfe490ceda50e812f83b7d1de77",
   "source_map_stack_trace_rev": "8eabd96b1811e30a11d3c54c9b4afae4fb72e98f",
   "source_maps_rev": "c07a01b8d5547ce3a47ee7a7a2b938a2bc09afe3",
   "source_span_rev": "8ae724c3e67f5afaacead44e93ff145bfb8775c7",
   "sse_rev": "9a54f1cdd91c8d79a6bf5ef8e849a12756607453",
-  "stack_trace_rev": "5220580872625ddee41e9ca9a5f3364789b2f0f6",
+  "stack_trace_rev": "17f09c2c6845bb31c7c385acecce5befb8527a13",
   "stream_channel_rev": "3fa3e40c75c210d617b8b943b9b8f580e9866a89",
   "string_scanner_rev": "6579871b528036767b3200b390a3ecef28e4900d",
   "sync_http_rev": "b6bd47965694dddffb6e62fb8a6c12d17c4ae4cd",
   "term_glyph_rev": "d0f205c67ea70eea47b9f41c8440129a72a9c86e",
-  "test_descriptor_rev": "ead23c1e7df079ac0f6457a35f7a71432892e527",
+  "test_descriptor_rev": "5ed5d7f6bf1191592995dcb8eedbbc17df69d386",
   "test_process_rev": "3e695bcfeab551473ddc288970f345f30e5e1375",
   "test_reflective_loader_rev": "8d0de01bbe852fea1f8e33aba907abcba50a8a1e",
   "test_rev": "d54846bc2b5cfa4e1445fda85c5e48a00940aa68",
   "typed_data_rev": "8b19e29bcf4077147de4d67adeabeb48270c65eb",
-  "usage_rev": "e85d575d6decb921c57a43b9844bba3607479f56",
+  "usage_rev": "79eef484e7403f24b414354a4af2008967484e46",
   "vector_math_rev": "1c72944e8c2f02340a1d90b32aab2e3836cef8cc",
-  "watcher_rev": "f76997ab0c857dc5537ac0975a9ada92b54ef949",
+  "watcher_rev": "e00c0ea769e32821d91c0880da8eb736839a6e6d",
   "web_components_rev": "8f57dac273412a7172c8ade6f361b407e2e4ed02",
   "web_socket_channel_rev": "99dbdc5769e19b9eeaf69449a59079153c6a8b1f",
   "WebCore_rev": "bcb10901266c884e7b3740abc597ab95373ab55c",

pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart

@@ -406,6 +406,18 @@ class _MatcherBuilder {
           ElementKind.setterKind
         ],
       );
+    } else if (container is ExtensionElement) {
+      _addMatcher(
+        components: [node.identifier.name, container.displayName],
+        kinds: const [
+          ElementKind.constantKind,
+          ElementKind.fieldKind,
+          ElementKind.functionKind, // tear-off
+          ElementKind.getterKind,
+          ElementKind.methodKind, // tear-off
+          ElementKind.setterKind
+        ],
+      );
     }
   }
 

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -777,6 +777,9 @@ class FixProcessor extends BaseProcessor {
     CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER_DEFAULT: [
       AddSuperConstructorInvocation.new,
     ],
+    CompileTimeErrorCode.UNDEFINED_EXTENSION_GETTER: [
+      DataDriven.new,
+    ],
     CompileTimeErrorCode.UNDEFINED_FUNCTION: [
       DataDriven.new,
       ImportLibrary.forExtension,

pkg/analysis_server/test/src/analytics/google_analytics_manager_test.dart

@@ -20,11 +20,7 @@ void main() {
 @reflectiveTest
 class GoogleAnalyticsManagerTest {
   final analytics = _MockAnalytics();
-  late final GoogleAnalyticsManager manager;
-
-  void setUp() {
-    manager = GoogleAnalyticsManager(analytics);
-  }
+  late final manager = GoogleAnalyticsManager(analytics);
 
   void test_plugin_request() {
     _defaultStartup();

pkg/analysis_server/test/src/services/correction/fix/data_driven/rename_test.dart

@@ -833,6 +833,29 @@ void f() {
     await assertHasFix('''
 import '$importUri';
 
+void f() {
+  C.b;
+}
+''');
+  }
+
+  Future<void> test_static_reference_removed_extension() async {
+    setPackageContent('''
+extension C {
+  static int b;
+}
+''');
+    setPackageData(_rename(['a', 'C'], 'b'));
+    await resolveTestCode('''
+import '$importUri';
+
+void f() {
+  C.a;
+}
+''');
+    await assertHasFix('''
+import '$importUri';
+
 void f() {
   C.b;
 }

pkg/analyzer/test/src/dart/resolution/instance_creation_test.dart

@@ -656,11 +656,11 @@ InstanceCreationExpression
           argumentList: ArgumentList
             leftParenthesis: (
             rightParenthesis: )
-          parameter: <null>
           staticInvokeType: C? Function()
           staticType: C?
           typeArgumentTypes
             C?
+        parameter: self::@class::X::@constructor::•::@parameter::c
       MethodInvocation
         methodName: SimpleIdentifier
           token: g2
@@ -689,11 +689,11 @@ InstanceCreationExpression
           argumentList: ArgumentList
             leftParenthesis: (
             rightParenthesis: )
-          parameter: <null>
           staticInvokeType: D? Function()
           staticType: D?
           typeArgumentTypes
             D?
+        parameter: self::@class::X::@constructor::•::@parameter::d
     rightParenthesis: )
   staticType: X
 ''');

pkg/analyzer/test/src/dart/resolution/method_invocation_test.dart

@@ -702,11 +702,11 @@ MethodInvocation
           argumentList: ArgumentList
             leftParenthesis: (
             rightParenthesis: )
-          parameter: <null>
           staticInvokeType: C? Function()
           staticType: C?
           typeArgumentTypes
             C?
+        parameter: self::@function::foo::@parameter::c
       MethodInvocation
         methodName: SimpleIdentifier
           token: g2
@@ -735,11 +735,11 @@ MethodInvocation
           argumentList: ArgumentList
             leftParenthesis: (
             rightParenthesis: )
-          parameter: <null>
           staticInvokeType: D? Function()
           staticType: D?
           typeArgumentTypes
             D?
+        parameter: self::@function::foo::@parameter::d
     rightParenthesis: )
   staticInvokeType: void Function(A, B, {C? c, D? d})
   staticType: void
@@ -7388,8 +7388,8 @@ MethodInvocation
           colon: :
         expression: BooleanLiteral
           literal: false
-          parameter: <null>
           staticType: bool
+        parameter: self::@function::foo::@parameter::b
       NamedExpression
         name: Label
           label: SimpleIdentifier
@@ -7399,8 +7399,8 @@ MethodInvocation
           colon: :
         expression: IntegerLiteral
           literal: 0
-          parameter: <null>
           staticType: int
+        parameter: self::@function::foo::@parameter::a
     rightParenthesis: )
   staticInvokeType: void Function({int? a, bool? b})
   staticType: void
@@ -7424,8 +7424,8 @@ MethodInvocation
           colon: :
         expression: BooleanLiteral
           literal: false
-          parameter: <null>
           staticType: bool*
+        parameter: self::@function::foo::@parameter::b
       NamedExpression
         name: Label
           label: SimpleIdentifier
@@ -7435,8 +7435,8 @@ MethodInvocation
           colon: :
         expression: IntegerLiteral
           literal: 0
-          parameter: <null>
           staticType: int*
+        parameter: self::@function::foo::@parameter::a
     rightParenthesis: )
   staticInvokeType: void Function({int* a, bool* b})*
   staticType: void

pkg/analyzer/test/src/summary/resolved_ast_printer.dart

@@ -830,6 +830,7 @@ class ResolvedAstPrinter extends ThrowingAstVisitor<void> {
     _writeln('NamedExpression');
     _withIndent(() {
       _writeNamedChildEntities(node);
+      _writeParameterElement(node);
     });
   }
 
@@ -1461,8 +1462,7 @@ class ResolvedAstPrinter extends ThrowingAstVisitor<void> {
       if (parent is ArgumentList ||
           parent is AssignmentExpression && parent.rightHandSide == node ||
           parent is BinaryExpression && parent.rightOperand == node ||
-          parent is IndexExpression && parent.index == node ||
-          parent is NamedExpression && parent.expression == node) {
+          parent is IndexExpression && parent.index == node) {
         _writeElement('parameter', node.staticParameterElement);
       }
     }

pkg/compiler/lib/src/inferrer/engine.dart

@@ -261,10 +261,6 @@ class InferrerEngine {
 
     info.bailedOut = false;
     info.elementType.inferred = true;
-    if (abstractValueDomain.isSpecializationOf(
-        info.originalType, abstractValueDomain.fixedListType)) {
-      info.checksGrowable = tracer.callsGrowableMethod;
-    }
     tracer.inputs.forEach(info.elementType.addInput);
     // Enqueue the list for later refinement
     _workQueue.add(info);