Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 694756b

Browse files
author
Jonah Williams
authored
[Impeller] delete specific vertices shader. (#52360)
Once #52348 and #52345 land we can delete this shader Part of flutter/flutter#143540
1 parent 19c182f commit 694756b

File tree

7 files changed

+0
-515
lines changed

7 files changed

+0
-515
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40501,7 +40501,6 @@ ORIGIN: ../../../flutter/impeller/entity/shaders/gradients/radial_gradient_fill.
4050140501
ORIGIN: ../../../flutter/impeller/entity/shaders/gradients/radial_gradient_ssbo_fill.frag + ../../../flutter/LICENSE
4050240502
ORIGIN: ../../../flutter/impeller/entity/shaders/gradients/sweep_gradient_fill.frag + ../../../flutter/LICENSE
4050340503
ORIGIN: ../../../flutter/impeller/entity/shaders/gradients/sweep_gradient_ssbo_fill.frag + ../../../flutter/LICENSE
40504-
ORIGIN: ../../../flutter/impeller/entity/shaders/position_color.vert + ../../../flutter/LICENSE
4050540504
ORIGIN: ../../../flutter/impeller/entity/shaders/rrect_blur.frag + ../../../flutter/LICENSE
4050640505
ORIGIN: ../../../flutter/impeller/entity/shaders/rrect_blur.vert + ../../../flutter/LICENSE
4050740506
ORIGIN: ../../../flutter/impeller/entity/shaders/runtime_effect.vert + ../../../flutter/LICENSE
@@ -40513,7 +40512,6 @@ ORIGIN: ../../../flutter/impeller/entity/shaders/texture_fill_strict_src.frag +
4051340512
ORIGIN: ../../../flutter/impeller/entity/shaders/texture_uv_fill.vert + ../../../flutter/LICENSE
4051440513
ORIGIN: ../../../flutter/impeller/entity/shaders/tiled_texture_fill.frag + ../../../flutter/LICENSE
4051540514
ORIGIN: ../../../flutter/impeller/entity/shaders/tiled_texture_fill_external.frag + ../../../flutter/LICENSE
40516-
ORIGIN: ../../../flutter/impeller/entity/shaders/vertices.frag + ../../../flutter/LICENSE
4051740515
ORIGIN: ../../../flutter/impeller/geometry/color.cc + ../../../flutter/LICENSE
4051840516
ORIGIN: ../../../flutter/impeller/geometry/color.h + ../../../flutter/LICENSE
4051940517
ORIGIN: ../../../flutter/impeller/geometry/constants.cc + ../../../flutter/LICENSE
@@ -43379,7 +43377,6 @@ FILE: ../../../flutter/impeller/entity/shaders/gradients/radial_gradient_fill.fr
4337943377
FILE: ../../../flutter/impeller/entity/shaders/gradients/radial_gradient_ssbo_fill.frag
4338043378
FILE: ../../../flutter/impeller/entity/shaders/gradients/sweep_gradient_fill.frag
4338143379
FILE: ../../../flutter/impeller/entity/shaders/gradients/sweep_gradient_ssbo_fill.frag
43382-
FILE: ../../../flutter/impeller/entity/shaders/position_color.vert
4338343380
FILE: ../../../flutter/impeller/entity/shaders/rrect_blur.frag
4338443381
FILE: ../../../flutter/impeller/entity/shaders/rrect_blur.vert
4338543382
FILE: ../../../flutter/impeller/entity/shaders/runtime_effect.vert
@@ -43391,7 +43388,6 @@ FILE: ../../../flutter/impeller/entity/shaders/texture_fill_strict_src.frag
4339143388
FILE: ../../../flutter/impeller/entity/shaders/texture_uv_fill.vert
4339243389
FILE: ../../../flutter/impeller/entity/shaders/tiled_texture_fill.frag
4339343390
FILE: ../../../flutter/impeller/entity/shaders/tiled_texture_fill_external.frag
43394-
FILE: ../../../flutter/impeller/entity/shaders/vertices.frag
4339543391
FILE: ../../../flutter/impeller/geometry/color.cc
4339643392
FILE: ../../../flutter/impeller/geometry/color.h
4339743393
FILE: ../../../flutter/impeller/geometry/constants.cc

impeller/entity/BUILD.gn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ impeller_shaders("entity_shaders") {
2424
"shaders/glyph_atlas.vert",
2525
"shaders/gradients/gradient_fill.vert",
2626
"shaders/gradients/linear_gradient_fill.frag",
27-
"shaders/position_color.vert",
2827
"shaders/gradients/radial_gradient_fill.frag",
2928
"shaders/rrect_blur.vert",
3029
"shaders/rrect_blur.frag",
@@ -38,7 +37,6 @@ impeller_shaders("entity_shaders") {
3837
"shaders/tiled_texture_fill.frag",
3938
"shaders/tiled_texture_fill_external.frag",
4039
"shaders/texture_fill_strict_src.frag",
41-
"shaders/vertices.frag",
4240
"shaders/blending/porter_duff_blend.frag",
4341
"shaders/blending/porter_duff_blend.vert",
4442
"shaders/filters/border_mask_blur.frag",

impeller/entity/contents/content_context.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,6 @@ ContentContext::ContentContext(
439439
GetContext()->GetCapabilities()->GetDefaultGlyphAtlasFormat() ==
440440
PixelFormat::kA8UNormInt)});
441441
glyph_atlas_color_pipelines_.CreateDefault(*context_, options);
442-
geometry_color_pipelines_.CreateDefault(*context_, options);
443442
yuv_to_rgb_filter_pipelines_.CreateDefault(*context_, options_trianglestrip);
444443
porter_duff_blend_pipelines_.CreateDefault(*context_, options_trianglestrip,
445444
{supports_decal});

impeller/entity/contents/content_context.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
#include "impeller/entity/morphology_filter.frag.h"
4747
#include "impeller/entity/porter_duff_blend.frag.h"
4848
#include "impeller/entity/porter_duff_blend.vert.h"
49-
#include "impeller/entity/position_color.vert.h"
5049
#include "impeller/entity/radial_gradient_fill.frag.h"
5150
#include "impeller/entity/rrect_blur.frag.h"
5251
#include "impeller/entity/rrect_blur.vert.h"
@@ -59,7 +58,6 @@
5958
#include "impeller/entity/texture_fill_strict_src.frag.h"
6059
#include "impeller/entity/texture_uv_fill.vert.h"
6160
#include "impeller/entity/tiled_texture_fill.frag.h"
62-
#include "impeller/entity/vertices.frag.h"
6361
#include "impeller/entity/yuv_to_rgb_filter.frag.h"
6462

6563
#include "impeller/typographer/glyph_atlas.h"
@@ -158,9 +156,6 @@ using PorterDuffBlendPipeline =
158156
PorterDuffBlendFragmentShader>;
159157
using ClipPipeline = RenderPipelineHandle<ClipVertexShader, ClipFragmentShader>;
160158

161-
using GeometryColorPipeline =
162-
RenderPipelineHandle<PositionColorVertexShader, VerticesFragmentShader>;
163-
164159
// Advanced blends
165160
using BlendColorPipeline = RenderPipelineHandle<AdvancedBlendVertexShader,
166161
AdvancedBlendFragmentShader>;
@@ -526,11 +521,6 @@ class ContentContext {
526521
return GetPipeline(glyph_atlas_color_pipelines_, opts);
527522
}
528523

529-
std::shared_ptr<Pipeline<PipelineDescriptor>> GetGeometryColorPipeline(
530-
ContentContextOptions opts) const {
531-
return GetPipeline(geometry_color_pipelines_, opts);
532-
}
533-
534524
std::shared_ptr<Pipeline<PipelineDescriptor>> GetYUVToRGBFilterPipeline(
535525
ContentContextOptions opts) const {
536526
return GetPipeline(yuv_to_rgb_filter_pipelines_, opts);
@@ -928,7 +918,6 @@ class ContentContext {
928918
mutable Variants<ClipPipeline> clip_pipelines_;
929919
mutable Variants<GlyphAtlasPipeline> glyph_atlas_pipelines_;
930920
mutable Variants<GlyphAtlasColorPipeline> glyph_atlas_color_pipelines_;
931-
mutable Variants<GeometryColorPipeline> geometry_color_pipelines_;
932921
mutable Variants<YUVToRGBFilterPipeline> yuv_to_rgb_filter_pipelines_;
933922
mutable Variants<PorterDuffBlendPipeline> porter_duff_blend_pipelines_;
934923
// Advanced blends.

impeller/entity/shaders/position_color.vert

Lines changed: 0 additions & 21 deletions
This file was deleted.

impeller/entity/shaders/vertices.frag

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)