Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 6ebd263

Browse files
nateboschCommit Bot
authored andcommitted
Use any deps for all unpublished packages
It should not be necessary to ever run `pub get` for a package which is not published. All packages used in the SDK are controlled by a single package config, so it's not necessary to declare versions or paths for any packages. Remove all dependency overrides. R=devoncarew@google.com Change-Id: Icb328813b471f35ee4c99995f4e90aac4d8ed438 Tested: Covered by existing static analysis. Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244767 Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Devon Carew <devoncarew@google.com>
1 parent 09b7f36 commit 6ebd263

File tree

30 files changed

+167
-405
lines changed

30 files changed

+167
-405
lines changed

pkg/_js_interop_checks/pubspec.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,4 @@ environment:
77

88
dependencies:
99
_fe_analyzer_shared: any
10-
kernel:
11-
path: ../kernel
12-
13-
dependency_overrides:
14-
_fe_analyzer_shared:
15-
path: ../_fe_analyzer_shared
10+
kernel: any

pkg/analysis_server/pubspec.yaml

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -6,43 +6,29 @@ environment:
66
sdk: '>=2.17.0 <3.0.0'
77

88
dependencies:
9-
_fe_analyzer_shared:
10-
path: ../_fe_analyzer_shared
11-
analyzer:
12-
path: ../analyzer
13-
analyzer_plugin:
14-
path: ../analyzer_plugin
9+
_fe_analyzer_shared: any
10+
analyzer: any
11+
analyzer_plugin: any
1512
args: any
1613
collection: any
1714
convert: any
1815
crypto: any
1916
dart_style: any
20-
http: any
2117
html: any
18+
http: any
2219
linter: any
23-
meta:
24-
path: ../meta
20+
meta: any
21+
path: any
2522
stream_channel: any
26-
telemetry:
27-
path: ../telemetry
23+
telemetry: any
2824
test: any
29-
path: any
3025
watcher: any
3126
yaml: any
3227

3328
dev_dependencies:
34-
analyzer_utilities:
35-
path: ../analyzer_utilities
29+
analyzer_utilities: any
3630
cli_util: any
37-
lints: ^2.0.0
31+
lints: any
3832
logging: any
3933
matcher: any
4034
test_reflective_loader: any
41-
42-
dependency_overrides:
43-
_fe_analyzer_shared:
44-
path: ../_fe_analyzer_shared
45-
analyzer:
46-
path: ../analyzer
47-
meta:
48-
path: ../meta

pkg/analyzer_cli/pubspec.yaml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,13 @@ environment:
1010
dependencies:
1111
analyzer: any
1212
args: any
13-
linter: ^1.0.0
13+
linter: any
1414
meta: any
1515
path: any
16-
pub_semver: ^2.0.0
16+
pub_semver: any
1717
yaml: any
1818

1919
dev_dependencies:
2020
lints: any
21-
test_reflective_loader: ^0.2.0
22-
test: ^1.0.0
23-
24-
dependency_overrides:
25-
analyzer:
26-
path: ../analyzer
27-
meta:
28-
path: ../meta
21+
test_reflective_loader: any
22+
test: any

pkg/analyzer_utilities/pubspec.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ environment:
66
sdk: '>=2.12.0 <3.0.0'
77

88
dependencies:
9-
analyzer:
10-
path: ../analyzer
9+
analyzer: any
1110
html: any
12-
meta:
13-
path: ../meta
11+
meta: any
1412
path: any
1513
test: any
1614

pkg/async_helper/pubspec.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,4 @@ environment:
1313
sdk: '>=2.12.0 <3.0.0'
1414

1515
dependencies:
16-
expect:
17-
path: ../expect
16+
expect: any

pkg/build_integration/pubspec.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ environment:
99
sdk: '>=2.12.0 <3.0.0'
1010

1111
dependencies:
12-
front_end:
13-
path: ../front_end
12+
front_end: any
1413

1514
dev_dependencies:
1615
test: any

pkg/compiler/pubspec.yaml

Lines changed: 13 additions & 98 deletions
Original file line numberDiff line numberDiff line change
@@ -10,110 +10,25 @@ environment:
1010
# package. The `.packages` file in the repository root will be used by default.
1111
dependencies:
1212
_fe_analyzer_shared: any
13-
# Published packages - repo version ensured via dependency_overrides
13+
_js_interop_checks: any
1414
collection: any
1515
crypto: any
16-
dart2js_info:
17-
path: ../dart2js_info
18-
front_end:
19-
path: ../front_end
20-
kernel:
21-
path: ../kernel
22-
23-
# Unpublished packages that can be used via path dependency
24-
_js_interop_checks:
25-
path: ../_js_interop_checks
26-
js_ast:
27-
path: ../js_ast
28-
js_runtime:
29-
path: ../js_runtime
16+
dart2js_info: any
17+
front_end: any
18+
js_ast: any
19+
js_runtime: any
20+
kernel: any
3021

3122
dev_dependencies:
32-
# Published packages - repo version ensured via dependency_overrides
3323
args: any
3424
dart_style: any
3525
http: any
36-
js:
37-
path: ../js
26+
js: any
3827
path: any
3928
source_maps: any
40-
# Unpublished packages that can be used via path dependency
41-
async_helper:
42-
path: ../async_helper
43-
dart2js_tools:
44-
path: ../dart2js_tools
45-
expect:
46-
path: ../expect
47-
modular_test:
48-
path: ../modular_test
49-
sourcemap_testing:
50-
path: ../sourcemap_testing
51-
testing:
52-
path: ../testing
53-
54-
dependency_overrides:
55-
# Packages with source in the SDK
56-
_fe_analyzer_shared:
57-
path: ../_fe_analyzer_shared
58-
analyzer:
59-
path: ../analyzer
60-
front_end:
61-
path: ../front_end
62-
js:
63-
path: ../js
64-
kernel:
65-
path: ../kernel
66-
meta:
67-
path: ../meta
68-
dart2js_info:
69-
path: ../dart2js_info
70-
smith:
71-
path: ../smith
72-
73-
# Packages brought in via DEPS
74-
args:
75-
path: ../../third_party/pkg/args
76-
async:
77-
path: ../../third_party/pkg/async
78-
charcode:
79-
path: ../../third_party/pkg/charcode
80-
collection:
81-
path: ../../third_party/pkg/collection
82-
convert:
83-
path: ../../third_party/pkg/convert
84-
crypto:
85-
path: ../../third_party/pkg/crypto
86-
fixnum:
87-
path: ../../third_party/pkg/fixnum
88-
http_parser:
89-
path: ../../third_party/pkg/http_parser
90-
matcher:
91-
path: ../../third_party/pkg/matcher
92-
mime:
93-
path: ../../third_party/pkg/mime
94-
package_config:
95-
path: ../../third_party/pkg_tested/package_config
96-
path:
97-
path: ../../third_party/pkg/path
98-
protobuf:
99-
path: ../../third_party/pkg/protobuf/protobuf
100-
shelf:
101-
path: ../../third_party/pkg/shelf/pkgs/shelf
102-
shelf_static:
103-
path: ../../third_party/pkg/shelf/pkgs/shelf_static
104-
source_span:
105-
path: ../../third_party/pkg/source_span
106-
stack_trace:
107-
path: ../../third_party/pkg/stack_trace
108-
stream_channel:
109-
path: ../../third_party/pkg/stream_channel
110-
string_scanner:
111-
path: ../../third_party/pkg/string_scanner
112-
test:
113-
path: ../../third_party/pkg/test/pkgs/test
114-
test_api:
115-
path: ../../third_party/pkg/test/pkgs/test_api
116-
typed_data:
117-
path: ../../third_party/pkg/typed_data
118-
yaml:
119-
path: ../../third_party/pkg/yaml
29+
async_helper: any
30+
dart2js_tools: any
31+
expect: any
32+
modular_test: any
33+
sourcemap_testing: any
34+
testing: any

pkg/dart2js_info/pubspec.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@ environment:
99
sdk: '>=2.11.99 <3.0.0'
1010

1111
dependencies:
12-
args: ^2.3.0
13-
collection: ^1.10.1
14-
fixnum: '>=0.10.5 <2.0.0'
15-
path: ^1.3.6
16-
protobuf: '>=1.0.1 <3.0.0'
17-
shelf: ^1.2.0
18-
yaml: ^3.1.0
12+
args: any
13+
collection: any
14+
fixnum: any
15+
path: any
16+
protobuf: any
17+
shelf: any
18+
yaml: any
1919

2020
dev_dependencies:
2121
lints: any
22-
test: ^1.2.0
22+
test: any
2323

2424
executables:
2525
dart2js_info: tools

pkg/dart2js_runtime_metrics/pubspec.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,4 @@ environment:
1212
sdk: ">=2.14.0 <2.15.0"
1313

1414
dev_dependencies:
15-
# Unpublished packages that can be used via path dependency
16-
expect:
17-
path: ../expect
15+
expect: any

pkg/dart2js_tools/pubspec.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@ publish_to: none
44
description: >
55
Collection of tools used with dart2js including analyzing compilation
66
information, deobfuscation of stack-traces and minified names.
7+
8+
environment:
9+
sdk: '>=2.12.0 <3.0.0'
10+
711
dependencies:
812
path: any
9-
source_maps: ^0.10.10
13+
source_maps: any
1014
source_span: any
11-
stack_trace: ^1.9.3
12-
environment:
13-
sdk: '>=2.12.0 <3.0.0'
15+
stack_trace: any

0 commit comments

Comments
 (0)