Yegor's comments.

Author: eyebrowsoffire

lib/web_ui/dev/felt_config.dart

@@ -66,10 +66,10 @@ class ArtifactDependencies {
     required this.skwasm
   });
 
-  ArtifactDependencies.none()
-    : canvasKit = false
-    , canvasKitChromium = false
-    , skwasm = false;
+  ArtifactDependencies.none() :
+    canvasKit = false,
+    canvasKitChromium = false,
+    skwasm = false;
   final bool canvasKit;
   final bool canvasKitChromium;
   final bool skwasm;
@@ -214,19 +214,16 @@ class FeltConfig {
                 throw AssertionError('Artifact dep $dep listed twice in suite $name.');
               }
               canvasKit = true;
-              break;
             case 'canvaskit_chromium':
               if (canvasKitChromium) {
                 throw AssertionError('Artifact dep $dep listed twice in suite $name.');
               }
               canvasKitChromium = true;
-              break;
             case 'skwasm':
               if (skwasm) {
                 throw AssertionError('Artifact dep $dep listed twice in suite $name.');
               }
               skwasm = true;
-              break;
             default:
               throw AssertionError('Unrecognized artifact dependency: $dep');
           }

lib/web_ui/dev/pipeline.dart

@@ -8,6 +8,7 @@ import 'dart:io' as io;
 import 'package:path/path.dart' as path;
 import 'package:watcher/watcher.dart';
 
+import 'exceptions.dart';
 import 'utils.dart';
 
 /// Describes what [Pipeline] is currently doing.
@@ -87,6 +88,13 @@ abstract class ProcessStep implements PipelineStep {
   }
 }
 
+class _PipelineStepFailure {
+  _PipelineStepFailure(this.step, this.error);
+
+  final PipelineStep step;
+  final Object error;
+}
+
 /// Executes a sequence of asynchronous tasks, typically as part of a build/test
 /// process.
 ///
@@ -112,27 +120,34 @@ class Pipeline {
   ///
   /// Returns a future that resolves after all steps have been performed.
   ///
-  /// The future resolves to an error as soon as any of the steps fails.
+  /// If any steps fail, the pipeline attempts to continue to subsequent steps,
+  /// but will fail at the end.
   ///
   /// The pipeline may be interrupted by calling [stop] before the future
   /// resolves.
   Future<void> run() async {
     _status = PipelineStatus.started;
-    try {
-      for (final PipelineStep step in steps) {
-        if (status != PipelineStatus.started) {
-          break;
-        }
-        _currentStep = step;
-        _currentStepFuture = step.run();
+    final List<_PipelineStepFailure> failures = <_PipelineStepFailure>[];
+    for (final PipelineStep step in steps) {
+      _currentStep = step;
+      _currentStepFuture = step.run();
+      try {
         await _currentStepFuture;
+      } catch (e) {
+        failures.add(_PipelineStepFailure(step, e));
+      } finally {
+        _currentStep = null;
       }
+    }
+    if (failures.isEmpty) {
       _status = PipelineStatus.done;
-    } catch (_) {
+    } else {
       _status = PipelineStatus.error;
-      rethrow;
-    } finally {
-      _currentStep = null;
+      print('Pipeline experienced the following failures:');
+      for (final _PipelineStepFailure failure in failures) {
+        print('  "${failure.step.description}": ${failure.error}');
+      }
+      throw ToolExit('Test pipeline failed.');
     }
   }
 

lib/web_ui/dev/steps/compile_bundle_step.dart

@@ -131,7 +131,22 @@ class CompileBundleStep implements PipelineStep {
       'results.json',
     ));
     outputResultsFile.writeAsStringSync(resultsJson);
-    print('\rCompleted compilation of ${bundle.name.ansiMagenta} in ${stopwatch.elapsedMilliseconds}ms.'.padRight(82));
+    final List<String> failedFiles = <String>[];
+    results.forEach((String fileName, CompileResult result) {
+      if (result == CompileResult.compilationFailure) {
+        failedFiles.add(fileName);
+      }
+    });
+    if (failedFiles.isEmpty) {
+      print('\rCompleted compilation of ${bundle.name.ansiMagenta} in ${stopwatch.elapsedMilliseconds}ms.'.padRight(82));
+    } else {
+      print('\rThe bundle ${bundle.name.ansiMagenta} compiled with some failures in ${stopwatch.elapsedMilliseconds}ms.');
+      print('Compilation failures:');
+      for (final String fileName in failedFiles) {
+        print('  $fileName');
+      }
+      throw ToolExit('Failed to compile ${bundle.name.ansiMagenta}.');
+    }
   }
 }
 
@@ -210,6 +225,7 @@ class Dart2JSCompiler extends TestCompiler {
       environment.dartExecutable,
       arguments,
       workingDirectory: inputTestSetDirectory.path,
+      failureIsSuccess: true,
       evalOutput: !isVerbose,
     );
     final int exitCode = await process.wait();
@@ -276,6 +292,7 @@ class Dart2WasmCompiler extends TestCompiler {
       environment.dartAotRuntimePath,
       arguments,
       workingDirectory: inputTestSetDirectory.path,
+      failureIsSuccess: true,
       evalOutput: true,
     );
     final int exitCode = await process.wait();

lib/web_ui/test/felt_config.yaml

@@ -1,3 +1,5 @@
+# See the `README.md` in this directory for documentation on the structure of
+# this file.
 compile-configs:
   - name: dart2js-html
     compiler: dart2js