Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 89f2b91

Browse files
authored
Remove --disable-service-auth-codes (#45356)
Discovered by a leakage as described in flutter/flutter#133824, this arg has likely been removed by Dart. Removing this arg eliminates the leakage warning. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 5f0db94 commit 89f2b91

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

runtime/dart_vm.cc

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,6 @@ static const char* kDartStartPausedArgs[]{
9090
"--pause_isolates_on_start",
9191
};
9292

93-
static const char* kDartDisableServiceAuthCodesArgs[]{
94-
"--disable-service-auth-codes",
95-
};
96-
9793
static const char* kDartEndlessTraceBufferArgs[]{
9894
"--timeline_recorder=endless",
9995
};
@@ -380,11 +376,6 @@ DartVM::DartVM(const std::shared_ptr<const DartVMData>& vm_data,
380376
PushBackAll(&args, kDartStartPausedArgs, fml::size(kDartStartPausedArgs));
381377
}
382378

383-
if (settings_.disable_service_auth_codes) {
384-
PushBackAll(&args, kDartDisableServiceAuthCodesArgs,
385-
fml::size(kDartDisableServiceAuthCodesArgs));
386-
}
387-
388379
if (settings_.endless_trace_buffer || settings_.trace_startup) {
389380
// If we are tracing startup, make sure the trace buffer is endless so we
390381
// don't lose early traces.

0 commit comments

Comments
 (0)