Revert "[Analyzer] Handle parameters that are both deprecated and required"

This reverts commit 9926189.

Reason for revert: Breaks the flutter build

Original change's description:
> [Analyzer] Handle parameters that are both deprecated and required
>
> Do not produce a diagnostic at the call-site in this case.
>
> Change-Id: I994704f77261b8e801a242c963236385f519eaa8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241008
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I2c6cbdcf8a08a178d77c6f875488f54f95788063
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

Author: bwilkerson

pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart

@@ -146,10 +146,6 @@ class DeprecatedMemberUseVerifier {
       return;
     }
 
-    if (element is ParameterElement && element.isNotOptional) {
-      return;
-    }
-
     var errorNode = node;
     var parent = node.parent;
     if (parent is AssignmentExpression && parent.leftHandSide == node) {
@@ -208,7 +204,11 @@ class DeprecatedMemberUseVerifier {
       _visitParametersAndArguments(
         element.parameters,
         arguments.arguments,
-        _checkForDeprecated,
+        (parameter, argument) {
+          if (parameter.isOptional) {
+            _checkForDeprecated(parameter, argument);
+          }
+        },
       );
     }
   }