[dart2js] Replace dart2js_dynamic_test with lint and appropriate lint ignores.

See patch 2 for failures coming from this new analysis option.

Change-Id: I6bb10c2eb12431f6c503cc817a9c9bb45ba597a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269800
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>

Author: natebiggs

pkg/compiler/analysis_options.yaml

@@ -11,6 +11,7 @@ analyzer:
 linter:
   rules:
     - annotate_overrides
+    - avoid_dynamic_calls
     - prefer_final_fields
     - prefer_if_null_operators
     - prefer_null_aware_operators

pkg/compiler/lib/src/constants/constant_system.dart

@@ -307,6 +307,7 @@ class BitAndOperation extends BinaryBitOperation {
   BigInt foldInts(BigInt left, BigInt right) => left & right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left & right;
 }
 
@@ -320,6 +321,7 @@ class BitOrOperation extends BinaryBitOperation {
   BigInt foldInts(BigInt left, BigInt right) => left | right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left | right;
 }
 
@@ -333,6 +335,7 @@ class BitXorOperation extends BinaryBitOperation {
   BigInt foldInts(BigInt left, BigInt right) => left ^ right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left ^ right;
 }
 
@@ -351,6 +354,7 @@ class ShiftLeftOperation extends BinaryBitOperation {
   }
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left << right;
 }
 
@@ -384,6 +388,7 @@ class ShiftRightOperation extends BinaryBitOperation {
   }
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left >> right;
 }
 
@@ -498,6 +503,7 @@ class SubtractOperation extends ArithmeticNumOperation {
   num foldNums(num left, num right) => left - right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left - right;
 }
 
@@ -514,6 +520,7 @@ class MultiplyOperation extends ArithmeticNumOperation {
   num foldNums(num left, num right) => left * right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left * right;
 }
 
@@ -533,6 +540,7 @@ class ModuloOperation extends ArithmeticNumOperation {
   num foldNums(num left, num right) => left % right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left % right;
 }
 
@@ -552,6 +560,7 @@ class RemainderOperation extends ArithmeticNumOperation {
   num foldNums(num left, num right) => left.remainder(right);
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left.remainder(right);
 }
 
@@ -575,6 +584,7 @@ class TruncatingDivideOperation extends ArithmeticNumOperation {
   }
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left ~/ right;
 
   @override
@@ -597,6 +607,7 @@ class DivideOperation extends ArithmeticNumOperation {
   bool isDivide() => true;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left / right;
 }
 
@@ -631,6 +642,7 @@ class AddOperation implements BinaryOperation {
   }
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left + right;
 }
 
@@ -669,6 +681,7 @@ class LessOperation extends RelationalNumOperation {
   bool foldNums(num left, num right) => left < right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left < right;
 }
 
@@ -685,6 +698,7 @@ class LessEqualOperation extends RelationalNumOperation {
   bool foldNums(num left, num right) => left <= right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left <= right;
 }
 
@@ -701,6 +715,7 @@ class GreaterOperation extends RelationalNumOperation {
   bool foldNums(num left, num right) => left > right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left > right;
 }
 
@@ -717,6 +732,7 @@ class GreaterEqualOperation extends RelationalNumOperation {
   bool foldNums(num left, num right) => left >= right;
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left >= right;
 }
 
@@ -823,6 +839,7 @@ class CodeUnitAtOperation implements BinaryOperation {
   }
 
   @override
+  // ignore: avoid_dynamic_calls
   apply(left, right) => left.codeUnitAt(right);
 }
 

pkg/compiler/lib/src/dart2js.dart

@@ -44,6 +44,7 @@ class OptionHandler {
   final bool multipleArguments;
 
   void handle(argument) {
+    // ignore: avoid_dynamic_calls
     (_handle as dynamic)(argument);
   }
 

pkg/compiler/lib/src/deferred_load/deferred_load.dart

@@ -585,6 +585,7 @@ class DeferredLoadTask extends CompilerTask {
         var element = d.entity;
         var elements = elementMap.putIfAbsent(importSet.unit!, () => []);
         var id = element.name ?? '$element';
+        // ignore: avoid_dynamic_calls
         var context = (element as dynamic).memberContext.name;
         id = element.name == null || element.name == '' ? '<anonymous>' : id;
         id = '$context.$id';

pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -794,6 +794,7 @@ class ProgramBuilder {
           (DartType type, String? name, ConstantValue? defaultValue) {
         if (parameterStructure.namedParameters.contains(name)) {
           assert(defaultValue != null);
+          // ignore: avoid_dynamic_calls
           optionalParameterDefaultValues[name] = defaultValue;
         }
       });
@@ -803,6 +804,7 @@ class ProgramBuilder {
       _elementEnvironment.forEachParameter(method,
           (DartType type, String? name, ConstantValue? defaultValue) {
         if (index >= parameterStructure.requiredPositionalParameters) {
+          // ignore: avoid_dynamic_calls
           optionalParameterDefaultValues.add(defaultValue);
         }
         index++;

pkg/compiler/lib/src/kernel/kernel_world.dart

@@ -165,7 +165,7 @@ class KClosedWorld implements BuiltWorld {
   bool isMemberUsed(MemberEntity member) => liveMemberUsage.containsKey(member);
 
   @override
-  void forEachGenericMethod(Function f) {
+  void forEachGenericMethod(void Function(FunctionEntity e) f) {
     liveMemberUsage.forEach((MemberEntity member, MemberUsage usage) {
       if (member is FunctionEntity &&
           elementEnvironment.getFunctionTypeVariables(member).isNotEmpty) {
@@ -175,7 +175,7 @@ class KClosedWorld implements BuiltWorld {
   }
 
   @override
-  void forEachGenericInstanceMethod(Function f) {
+  void forEachGenericInstanceMethod(void Function(FunctionEntity e) f) {
     liveMemberUsage.forEach((MemberEntity member, MemberUsage usage) {
       if (member is FunctionEntity &&
           member.isInstanceMember &&

pkg/compiler/lib/src/serialization/binary_sink.dart

@@ -72,6 +72,7 @@ class BinaryDataSink implements DataSink {
 
   @override
   void writeEnum(dynamic value) {
+    // ignore: avoid_dynamic_calls
     writeInt(value.index);
   }
 

pkg/compiler/lib/src/ssa/interceptor_simplifier.dart

@@ -84,7 +84,10 @@ class SsaSimplifyInterceptors extends HBaseVisitor<bool>
     // possible that all uses can be rewritten to use different constants.
 
     HInstruction constant = tryComputeConstantInterceptor(
-        invoke.inputs[1], interceptor.interceptedClasses);
+        // ignore: avoid_dynamic_calls
+        invoke.inputs[1],
+        // ignore: avoid_dynamic_calls
+        interceptor.interceptedClasses);
     if (constant != null) {
       invoke.changeUse(interceptor, constant);
     }

pkg/compiler/lib/src/ssa/jump_handler.dart

@@ -133,14 +133,16 @@ class TargetJumpHandler implements JumpHandler {
   }
 
   @override
-  void forEachBreak(Function action) {
+  void forEachBreak(
+      void Function(HBreak instruction, LocalsHandler locals) action) {
     for (_JumpHandlerEntry entry in jumps) {
       if (entry.isBreak()) action(entry.jumpInstruction, entry.locals);
     }
   }
 
   @override
-  void forEachContinue(Function action) {
+  void forEachContinue(
+      void Function(HContinue instruction, LocalsHandler locals) action) {
     for (_JumpHandlerEntry entry in jumps) {
       if (entry.isContinue()) action(entry.jumpInstruction, entry.locals);
     }

pkg/compiler/lib/src/ssa/types_propagation.dart

@@ -35,7 +35,7 @@ class SsaTypePropagator extends HBaseVisitor<AbstractValue>
     implements OptimizationPhase {
   final Map<int, HInstruction> workmap = {};
   final List<int> worklist = [];
-  final Map<HInstruction, Function> pendingOptimizations = {};
+  final Map<HInstruction, void Function()> pendingOptimizations = {};
 
   final GlobalTypeInferenceResults results;
   final CommonElements commonElements;