Add a test that will fail if any of the files in analyzer_cli are not sorted by MemberSorter

Change-Id: I76d5caeef2b6525e93636f150579143a5b7e2c2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

Author: bwilkerson

pkg/analyzer_cli/test/all.dart

@@ -2,28 +2,30 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'analysis_options_test.dart' as analysis_options_test;
-import 'build_mode_test.dart' as build_mode_test;
-import 'driver_test.dart' as driver_test;
-import 'embedder_test.dart' as embedder_test;
-import 'errors_reported_once_test.dart' as errors_reported_once_test;
-import 'errors_upgrade_fails_cli_test.dart' as errors_upgrade_fails_cli_test;
-import 'options_test.dart' as options_test;
-import 'package_prefix_test.dart' as package_prefix_test;
-import 'perf_report_test.dart' as perf_report_test;
-import 'reporter_test.dart' as reporter_test;
-import 'strong_mode_test.dart' as strong_mode_test;
+import 'analysis_options_test.dart' as analysis_options;
+import 'build_mode_test.dart' as build_mode;
+import 'driver_test.dart' as driver;
+import 'embedder_test.dart' as embedder;
+import 'errors_reported_once_test.dart' as errors_reported_once;
+import 'errors_upgrade_fails_cli_test.dart' as errors_upgrade_fails_cli;
+import 'options_test.dart' as options;
+import 'package_prefix_test.dart' as package_prefix;
+import 'perf_report_test.dart' as perf_report;
+import 'reporter_test.dart' as reporter;
+import 'strong_mode_test.dart' as strong_mode;
+import 'verify_sorted_test.dart' as verify_sorted;
 
 void main() {
-  analysis_options_test.main();
-  build_mode_test.main();
-  driver_test.main();
-  embedder_test.main();
-  errors_reported_once_test.main();
-  errors_upgrade_fails_cli_test.main();
-  options_test.main();
-  package_prefix_test.main();
-  perf_report_test.main();
-  reporter_test.main();
-  strong_mode_test.main();
+  analysis_options.main();
+  build_mode.main();
+  driver.main();
+  embedder.main();
+  errors_reported_once.main();
+  errors_upgrade_fails_cli.main();
+  options.main();
+  package_prefix.main();
+  perf_report.main();
+  reporter.main();
+  strong_mode.main();
+  verify_sorted.main();
 }

pkg/analyzer_cli/test/utils.dart

@@ -13,6 +13,27 @@ import 'package:path/path.dart' as pathos;
 final String testDirectory = pathos.dirname(
     pathos.fromUri((reflectClass(_TestUtils).owner as LibraryMirror).uri));
 
+/// Returns a path to the directory containing source code for packages such as
+/// kernel, front_end, and analyzer.
+String get packageRoot {
+  // If the package root directory is specified on the command line using
+  // -DpkgRoot=..., use it.
+  var pkgRootVar = const String.fromEnvironment('pkgRoot');
+  if (pkgRootVar != null) {
+    var path = pathos.join(Directory.current.path, pkgRootVar);
+    if (!path.endsWith(pathos.separator)) path += pathos.separator;
+    return path;
+  }
+  // Otherwise try to guess based on the script path.
+  var scriptPath = pathos.fromUri(Platform.script);
+  var parts = pathos.split(scriptPath);
+  var pkgIndex = parts.indexOf('pkg');
+  if (pkgIndex != -1) {
+    return pathos.joinAll(parts.sublist(0, pkgIndex + 1)) + pathos.separator;
+  }
+  throw StateError('Unable to find sdk/pkg/ in $scriptPath');
+}
+
 /// Recursively copy the specified [src] directory (or file)
 /// to the specified destination path.
 Future<void> recursiveCopy(FileSystemEntity src, String dstPath) async {

pkg/analyzer_cli/test/verify_sorted_test.dart

@@ -0,0 +1,68 @@
+// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';
+
+import 'package:analysis_server/src/services/correction/sort_members.dart';
+import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
+import 'package:analyzer/dart/analysis/results.dart';
+import 'package:analyzer/dart/analysis/session.dart';
+import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/file_system/physical_file_system.dart';
+import 'package:test/test.dart';
+
+import 'utils.dart';
+
+void main() {
+  var provider = PhysicalResourceProvider.INSTANCE;
+  var normalizedRoot = provider.pathContext.normalize(packageRoot);
+  var packagePath = provider.pathContext.join(normalizedRoot, 'analyzer_cli');
+  var testDataPath = provider.pathContext.join(packagePath, 'test', 'data');
+
+  var collection = AnalysisContextCollection(
+      includedPaths: <String>[packagePath],
+      excludedPaths: [testDataPath],
+      resourceProvider: provider);
+  var contexts = collection.contexts;
+  if (contexts.length != 1) {
+    fail('The directory $packagePath contains multiple analysis contexts.');
+  }
+
+  buildTestsIn(contexts[0].currentSession, packagePath, testDataPath,
+      provider.getFolder(packagePath));
+}
+
+void buildTestsIn(AnalysisSession session, String testDirPath,
+    String testDataPath, Folder directory) {
+  var pathContext = session.resourceProvider.pathContext;
+  var children = directory.getChildren();
+  children.sort((first, second) => first.shortName.compareTo(second.shortName));
+  for (var child in children) {
+    if (child is Folder) {
+      if (child.path != testDataPath) {
+        buildTestsIn(session, testDirPath, testDataPath, child);
+      }
+    } else if (child is File && child.shortName.endsWith('.dart')) {
+      var path = child.path;
+      var relativePath = pathContext.relative(path, from: testDirPath);
+      test(relativePath, () {
+        var result = session.getParsedUnit(path);
+        if (result.state != ResultState.VALID) {
+          fail('Could not parse $path');
+        }
+        var code = result.content;
+        var unit = result.unit;
+        var errors = result.errors;
+        if (errors.isNotEmpty) {
+          fail('Errors found when parsing $path');
+        }
+        var sorter = MemberSorter(code, unit);
+        var edits = sorter.sort();
+        if (edits.isNotEmpty) {
+          fail('Unsorted file $path');
+        }
+      });
+    }
+  }
+}