Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d671b2d

Browse files
authored
Update skwasm build to use safer flush call (#45652)
Follow-up to #45644 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent f192cc9 commit d671b2d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/web_ui/skwasm/surface.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ void Surface::_renderPicture(const SkPicture* picture, uint32_t callbackId) {
148148
auto canvas = _surface->getCanvas();
149149
canvas->drawColor(SK_ColorTRANSPARENT, SkBlendMode::kSrc);
150150
canvas->drawPicture(sk_ref_sp<SkPicture>(picture), &matrix, nullptr);
151-
_grContext->flush(_surface);
151+
_grContext->flush(_surface.get());
152152
skwasm_captureImageBitmap(this, _glContext, callbackId,
153153
roundedOutRect.width(), roundedOutRect.height());
154154
}

0 commit comments

Comments
 (0)