Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit dc9643c

Browse files
author
jonahwilliams
committed
[Impeller] remove unused shader, format malioc diff
1 parent 674bcc0 commit dc9643c

File tree

8 files changed

+7588
-38
lines changed

8 files changed

+7588
-38
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,7 +1255,6 @@ ORIGIN: ../../../flutter/impeller/entity/shaders/linear_to_srgb_filter.frag + ..
12551255
ORIGIN: ../../../flutter/impeller/entity/shaders/linear_to_srgb_filter.vert + ../../../flutter/LICENSE
12561256
ORIGIN: ../../../flutter/impeller/entity/shaders/morphology_filter.frag + ../../../flutter/LICENSE
12571257
ORIGIN: ../../../flutter/impeller/entity/shaders/morphology_filter.vert + ../../../flutter/LICENSE
1258-
ORIGIN: ../../../flutter/impeller/entity/shaders/position.vert + ../../../flutter/LICENSE
12591258
ORIGIN: ../../../flutter/impeller/entity/shaders/position_color.vert + ../../../flutter/LICENSE
12601259
ORIGIN: ../../../flutter/impeller/entity/shaders/position_uv.vert + ../../../flutter/LICENSE
12611260
ORIGIN: ../../../flutter/impeller/entity/shaders/radial_gradient_fill.frag + ../../../flutter/LICENSE
@@ -3790,7 +3789,6 @@ FILE: ../../../flutter/impeller/entity/shaders/linear_to_srgb_filter.frag
37903789
FILE: ../../../flutter/impeller/entity/shaders/linear_to_srgb_filter.vert
37913790
FILE: ../../../flutter/impeller/entity/shaders/morphology_filter.frag
37923791
FILE: ../../../flutter/impeller/entity/shaders/morphology_filter.vert
3793-
FILE: ../../../flutter/impeller/entity/shaders/position.vert
37943792
FILE: ../../../flutter/impeller/entity/shaders/position_color.vert
37953793
FILE: ../../../flutter/impeller/entity/shaders/position_uv.vert
37963794
FILE: ../../../flutter/impeller/entity/shaders/radial_gradient_fill.frag

impeller/entity/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ impeller_shaders("entity_shaders") {
4545
"shaders/morphology_filter.vert",
4646
"shaders/position_color.vert",
4747
"shaders/position_uv.vert",
48-
"shaders/position.vert",
4948
"shaders/radial_gradient_fill.frag",
5049
"shaders/rrect_blur.vert",
5150
"shaders/rrect_blur.frag",

impeller/entity/contents/content_context.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,6 @@ ContentContext::ContentContext(std::shared_ptr<Context> context)
276276
CreateDefaultPipeline<GlyphAtlasSdfPipeline>(*context_);
277277
geometry_color_pipelines_[{}] =
278278
CreateDefaultPipeline<GeometryColorPipeline>(*context_);
279-
geometry_position_pipelines_[{}] =
280-
CreateDefaultPipeline<GeometryPositionPipeline>(*context_);
281279
yuv_to_rgb_filter_pipelines_[{}] =
282280
CreateDefaultPipeline<YUVToRGBFilterPipeline>(*context_);
283281

impeller/entity/contents/content_context.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
#include "impeller/renderer/pipeline.h"
5353
#include "impeller/scene/scene_context.h"
5454

55-
#include "impeller/entity/position.vert.h"
5655
#include "impeller/entity/position_color.vert.h"
5756

5857
#include "impeller/scene/scene_context.h"
@@ -152,8 +151,6 @@ using GlyphAtlasSdfPipeline =
152151
using ClipPipeline =
153152
RenderPipelineT<SolidFillVertexShader, SolidFillFragmentShader>;
154153

155-
using GeometryPositionPipeline =
156-
RenderPipelineT<PositionVertexShader, VerticesFragmentShader>;
157154
using GeometryColorPipeline =
158155
RenderPipelineT<PositionColorVertexShader, VerticesFragmentShader>;
159156
using YUVToRGBFilterPipeline =
@@ -427,11 +424,6 @@ class ContentContext {
427424
return GetPipeline(geometry_color_pipelines_, opts);
428425
}
429426

430-
std::shared_ptr<Pipeline<PipelineDescriptor>> GetGeometryPositionPipeline(
431-
ContentContextOptions opts) const {
432-
return GetPipeline(geometry_position_pipelines_, opts);
433-
}
434-
435427
std::shared_ptr<Pipeline<PipelineDescriptor>> GetYUVToRGBFilterPipeline(
436428
ContentContextOptions opts) const {
437429
return GetPipeline(yuv_to_rgb_filter_pipelines_, opts);
@@ -661,7 +653,6 @@ class ContentContext {
661653
mutable Variants<ClipPipeline> clip_pipelines_;
662654
mutable Variants<GlyphAtlasPipeline> glyph_atlas_pipelines_;
663655
mutable Variants<GlyphAtlasSdfPipeline> glyph_atlas_sdf_pipelines_;
664-
mutable Variants<GeometryPositionPipeline> geometry_position_pipelines_;
665656
mutable Variants<GeometryColorPipeline> geometry_color_pipelines_;
666657
mutable Variants<YUVToRGBFilterPipeline> yuv_to_rgb_filter_pipelines_;
667658
// Advanced blends.

impeller/entity/contents/vertices_contents.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#include "impeller/entity/contents/filters/color_filter_contents.h"
99
#include "impeller/entity/contents/filters/filter_contents.h"
1010
#include "impeller/entity/contents/texture_contents.h"
11-
#include "impeller/entity/position.vert.h"
1211
#include "impeller/entity/position_color.vert.h"
1312
#include "impeller/entity/vertices.frag.h"
1413
#include "impeller/geometry/color.h"

impeller/entity/shaders/position.vert

Lines changed: 0 additions & 21 deletions
This file was deleted.

impeller/tools/malioc.json

Lines changed: 7585 additions & 1 deletion
Large diffs are not rendered by default.

impeller/tools/malioc_diff.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ def read_malioc_file(malioc_tree, json_file):
119119
filename = os.path.relpath(shader['filename'], build_gen_dir)
120120
if filename.startswith('../..'):
121121
filename = filename[6:]
122+
if filename.startswith('../'):
123+
filename = filename[3:]
122124
result['filename'] = filename
123125
result['core'] = shader['hardware']['core']
124126
result['type'] = shader['shader']['type']
@@ -266,7 +268,7 @@ def main(argv):
266268
if args.update:
267269
# Write the new results to the file given by --before, then exit.
268270
with open(args.before, 'w') as file:
269-
json.dump(after_json, file, sort_keys=True)
271+
json.dump(after_json, file, sort_keys=True, indent=2)
270272
return 0
271273

272274
with open(args.before, 'r') as file:

0 commit comments

Comments
 (0)