jonah review

Author: bdero

impeller/fixtures/dart_tests.dart

@@ -191,7 +191,7 @@ void canCreateRenderPassAndSubmit() {
   final gpu.CommandBuffer commandBuffer = gpu.gpuContext.createCommandBuffer();
 
   final gpu.RenderTarget renderTarget = gpu.RenderTarget.singleColor(
-    colorAttachment: gpu.ColorAttachment(texture: renderTexture!),
+    gpu.ColorAttachment(texture: renderTexture!),
   );
   final gpu.RenderPass encoder = commandBuffer.createRenderPass(renderTarget);
 

lib/gpu/lib/src/render_pass.dart

@@ -85,17 +85,11 @@ base class RenderTarget {
       {this.colorAttachments = const <ColorAttachment>[],
       this.depthStencilAttachment});
 
-  factory RenderTarget.singleColor(
-      {ColorAttachment? colorAttachment,
-      DepthStencilAttachment? depthStencilAttachment}) {
-    List<ColorAttachment> colors = [];
-    if (colorAttachment != null) {
-      colors.add(colorAttachment);
-    }
-    return new RenderTarget(
-        colorAttachments: colors,
-        depthStencilAttachment: depthStencilAttachment);
-  }
+  RenderTarget.singleColor(ColorAttachment colorAttachment,
+      {DepthStencilAttachment? depthStencilAttachment})
+      : this(
+            colorAttachments: [colorAttachment],
+            depthStencilAttachment: depthStencilAttachment);
 
   final List<ColorAttachment> colorAttachments;
   final DepthStencilAttachment? depthStencilAttachment;