Version 2.19.0-328.0.dev

Merge e20d10e into dev

Author: Dart CI

DEPS

@@ -53,7 +53,7 @@ vars = {
   # hashes.
   "co19_rev": "83feddb44881181ad8f2487080dafe0909517b09",
   # This line prevents conflicts when both packages are rolled simultaneously.
-  "co19_2_rev": "17f2b4079f55bb5beb8f8301970089c290590ae4",
+  "co19_2_rev": "6dc80bd1ff15d0854eaba0c7e5d606ec0ad6b3db",
 
   # The internal benchmarks to use. See go/dart-benchmarks-internal
   "benchmarks_internal_rev": "599aa474a03c37be146f82dfbad85f34f25ffa47",

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -10543,7 +10543,7 @@ class RecordPatternFieldNameImpl extends AstNodeImpl
 ///        '(' [RecordPatternField] (',' [RecordPatternField])* ')'
 @experimental
 class RecordPatternImpl extends DartPatternImpl implements RecordPattern {
-  final NodeListImpl<RecordPatternField> _fields = NodeListImpl._();
+  final NodeListImpl<RecordPatternFieldImpl> _fields = NodeListImpl._();
 
   @override
   final Token leftParenthesis;
@@ -10553,7 +10553,7 @@ class RecordPatternImpl extends DartPatternImpl implements RecordPattern {
 
   RecordPatternImpl({
     required this.leftParenthesis,
-    required List<RecordPatternField> fields,
+    required List<RecordPatternFieldImpl> fields,
     required this.rightParenthesis,
   }) {
     _fields._initialize(this, fields);
@@ -10566,7 +10566,7 @@ class RecordPatternImpl extends DartPatternImpl implements RecordPattern {
   Token get endToken => rightParenthesis;
 
   @override
-  NodeList<RecordPatternField> get fields => _fields;
+  NodeList<RecordPatternFieldImpl> get fields => _fields;
 
   @override
   ChildEntities get _childEntities => super._childEntities
@@ -10587,7 +10587,12 @@ class RecordPatternImpl extends DartPatternImpl implements RecordPattern {
       DartType matchedType,
       Map<PromotableElement, VariableTypeInfo<AstNode, DartType>> typeInfos,
       MatchContext<AstNode, Expression> context) {
-    // TODO(scheglov) https://github.com/dart-lang/sdk/issues/50066
+    resolverVisitor.recordPatternResolver.resolve(
+      node: this,
+      matchedType: matchedType,
+      typeInfos: typeInfos,
+      context: context,
+    );
   }
 
   @override

pkg/analyzer/lib/src/dart/resolver/record_pattern_resolver.dart

@@ -0,0 +1,73 @@
+// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:_fe_analyzer_shared/src/type_inference/type_analysis_result.dart';
+import 'package:_fe_analyzer_shared/src/type_inference/type_analyzer.dart';
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/src/dart/ast/ast.dart';
+import 'package:analyzer/src/dart/element/extensions.dart';
+import 'package:analyzer/src/dart/element/type_provider.dart';
+import 'package:analyzer/src/error/codes.dart';
+import 'package:analyzer/src/generated/resolver.dart';
+
+class RecordPatternResolver {
+  final ResolverVisitor resolverVisitor;
+
+  int _positionalFieldIndex = 0;
+
+  RecordPatternResolver(this.resolverVisitor);
+
+  TypeProviderImpl get _typeProvider => resolverVisitor.typeProvider;
+
+  void resolve({
+    required RecordPatternImpl node,
+    required DartType matchedType,
+    required Map<PromotableElement, VariableTypeInfo<AstNode, DartType>>
+        typeInfos,
+    required MatchContext<AstNode, Expression> context,
+  }) {
+    _positionalFieldIndex = 0;
+    for (var field in node.fields) {
+      var fieldType = _resolveFieldType(matchedType, field);
+      field.pattern
+          .resolvePattern(resolverVisitor, fieldType, typeInfos, context);
+    }
+  }
+
+  DartType _resolveFieldType(
+    DartType matchedType,
+    RecordPatternFieldImpl field,
+  ) {
+    if (matchedType is RecordType) {
+      var fieldNameNode = field.fieldName;
+      if (fieldNameNode != null) {
+        var nameToken = fieldNameNode.name;
+        nameToken ??= field.pattern.variablePattern?.name;
+        if (nameToken == null) {
+          resolverVisitor.errorReporter.reportErrorForNode(
+            CompileTimeErrorCode.MISSING_EXTRACTOR_PATTERN_GETTER_NAME,
+            field,
+          );
+          return _typeProvider.dynamicType;
+        }
+
+        var fieldName = nameToken.lexeme;
+        var recordField = matchedType.fieldByName(fieldName);
+        if (recordField != null) {
+          return recordField.type;
+        }
+      } else {
+        if (_positionalFieldIndex < matchedType.positionalFields.length) {
+          return matchedType.positionalFields[_positionalFieldIndex++].type;
+        }
+      }
+    } else if (matchedType.isDynamic) {
+      return _typeProvider.dynamicType;
+    }
+
+    return resolverVisitor.typeSystem.objectQuestion;
+  }
+}

pkg/analyzer/lib/src/fasta/ast_builder.dart

@@ -4634,11 +4634,14 @@ class AstBuilder extends StackListener {
   void handleRecordPattern(Token token, int count) {
     debugEvent("RecordPattern");
 
-    var fields = popTypedList2<RecordPatternField>(count);
-    push(RecordPatternImpl(
+    var fields = popTypedList2<RecordPatternFieldImpl>(count);
+    push(
+      RecordPatternImpl(
         leftParenthesis: token,
         fields: fields,
-        rightParenthesis: token.endGroup!));
+        rightParenthesis: token.endGroup!,
+      ),
+    );
   }
 
   @override

pkg/analyzer/lib/src/generated/resolver.dart

@@ -57,6 +57,7 @@ import 'package:analyzer/src/dart/resolver/prefix_expression_resolver.dart';
 import 'package:analyzer/src/dart/resolver/prefixed_identifier_resolver.dart';
 import 'package:analyzer/src/dart/resolver/property_element_resolver.dart';
 import 'package:analyzer/src/dart/resolver/record_literal_resolver.dart';
+import 'package:analyzer/src/dart/resolver/record_pattern_resolver.dart';
 import 'package:analyzer/src/dart/resolver/scope.dart';
 import 'package:analyzer/src/dart/resolver/shared_type_analyzer.dart';
 import 'package:analyzer/src/dart/resolver/simple_identifier_resolver.dart';
@@ -281,6 +282,9 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
   late final ExtractorPatternResolver extractorPatternResolver =
       ExtractorPatternResolver(this);
 
+  late final RecordPatternResolver recordPatternResolver =
+      RecordPatternResolver(this);
+
   final bool genericMetadataIsEnabled;
 
   /// Stack for obtaining rewritten expressions.  Prior to visiting an