Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fc8dee9

Browse files
committed
[Impeller] updated gaussian blur tests to use device private textures
1 parent 900ce09 commit fc8dee9

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

impeller/entity/contents/filters/directional_gaussian_blur_filter_contents_unittests.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ TEST_P(DirectionalGaussianBlurFilterContentsTest, RenderNoCoverage) {
8989
TEST_P(DirectionalGaussianBlurFilterContentsTest,
9090
RenderCoverageMatchesGetCoverage) {
9191
TextureDescriptor desc = {
92+
.storage_mode = StorageMode::kDevicePrivate,
9293
.format = PixelFormat::kB8G8R8A8UNormInt,
9394
.size = ISize(100, 100),
9495
};

impeller/entity/contents/filters/gaussian_blur_filter_contents_unittests.cc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ TEST(GaussianBlurFilterContentsTest, CoverageWithSigma) {
7070

7171
TEST_P(GaussianBlurFilterContentsTest, CoverageWithTexture) {
7272
TextureDescriptor desc = {
73+
.storage_mode = StorageMode::kDevicePrivate,
7374
.format = PixelFormat::kB8G8R8A8UNormInt,
7475
.size = ISize(100, 100),
7576
};
@@ -88,6 +89,7 @@ TEST_P(GaussianBlurFilterContentsTest, CoverageWithTexture) {
8889

8990
TEST_P(GaussianBlurFilterContentsTest, CoverageWithEffectTransform) {
9091
TextureDescriptor desc = {
92+
.storage_mode = StorageMode::kDevicePrivate,
9193
.format = PixelFormat::kB8G8R8A8UNormInt,
9294
.size = ISize(100, 100),
9395
};
@@ -115,6 +117,7 @@ TEST(GaussianBlurFilterContentsTest, FilterSourceCoverage) {
115117

116118
TEST_P(GaussianBlurFilterContentsTest, RenderCoverageMatchesGetCoverage) {
117119
TextureDescriptor desc = {
120+
.storage_mode = StorageMode::kDevicePrivate,
118121
.format = PixelFormat::kB8G8R8A8UNormInt,
119122
.size = ISize(100, 100),
120123
};
@@ -146,6 +149,7 @@ TEST_P(GaussianBlurFilterContentsTest, RenderCoverageMatchesGetCoverage) {
146149
TEST_P(GaussianBlurFilterContentsTest,
147150
RenderCoverageMatchesGetCoverageTranslate) {
148151
TextureDescriptor desc = {
152+
.storage_mode = StorageMode::kDevicePrivate,
149153
.format = PixelFormat::kB8G8R8A8UNormInt,
150154
.size = ISize(100, 100),
151155
};
@@ -159,6 +163,7 @@ TEST_P(GaussianBlurFilterContentsTest,
159163
entity.SetTransform(Matrix::MakeTranslation({100, 200, 0}));
160164
std::optional<Entity> result =
161165
contents->GetEntity(*renderer, entity, /*coverage_hint=*/{});
166+
162167
EXPECT_TRUE(result.has_value());
163168
if (result.has_value()) {
164169
EXPECT_EQ(result.value().GetBlendMode(), BlendMode::kSourceOver);
@@ -178,6 +183,7 @@ TEST_P(GaussianBlurFilterContentsTest,
178183
TEST_P(GaussianBlurFilterContentsTest,
179184
RenderCoverageMatchesGetCoverageRotated) {
180185
TextureDescriptor desc = {
186+
.storage_mode = StorageMode::kDevicePrivate,
181187
.format = PixelFormat::kB8G8R8A8UNormInt,
182188
.size = ISize(400, 300),
183189
};
@@ -210,6 +216,7 @@ TEST_P(GaussianBlurFilterContentsTest,
210216

211217
TEST_P(GaussianBlurFilterContentsTest, CalculateUVsSimple) {
212218
TextureDescriptor desc = {
219+
.storage_mode = StorageMode::kDevicePrivate,
213220
.format = PixelFormat::kB8G8R8A8UNormInt,
214221
.size = ISize(100, 100),
215222
};

0 commit comments

Comments
 (0)