Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit feb8785

Browse files
lucferronCommit Bot
authored andcommitted
dEQP: Enable depth/stencil backbuffer.
This will make all the dEQP tests no longer return "not supported" when trying to do any depth/stencil work. With this comes a bunch of new tests suppressions to be able to proceed forward. Bug: angleproject:2425 Bug: angleproject:2426 Bug: angleproject:2427 Bug: angleproject:2428 Bug: angleproject:2429 Change-Id: I923026bb29c4ed1f4586b89176eea848fd2ceb71 Reviewed-on: https://chromium-review.googlesource.com/976339 Commit-Queue: Luc Ferron <lucferron@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 parent b1d81fe commit feb8785

File tree

4 files changed

+31
-2
lines changed

4 files changed

+31
-2
lines changed

src/tests/deqp_support/angle_deqp_gtest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const APIInfo *g_initAPI = nullptr;
6464
constexpr const char *g_deqpEGLConfigNameString = "--deqp-gl-config-name=";
6565

6666
// Default the config to RGBA8
67-
const char *g_eglConfigName = "rgba8888";
67+
const char *g_eglConfigName = "rgba8888d24s8";
6868

6969
// Returns the default API for a platform.
7070
const char *GetDefaultAPIName()

src/tests/deqp_support/deqp_egl_test_expectations.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@
6060
//
6161
////////////////////////////////////////////////////////////////////////////////
6262

63+
// Flaky since we enabled depth/stencil backbuffer in all tests.
64+
2429 WIN NVIDIA : dEQP-EGL.functional.query_context.query_context.rgba8888_window = FAIL
65+
6366
// TODO(jmadill): Triage these into permananent and temporary failures.
6467
1340 WIN : dEQP-EGL.functional.query_config.get_configs.get_configs_bounds = FAIL
6568
1340 WIN : dEQP-EGL.functional.choose_config.simple.selection_only.buffer_size = FAIL

src/tests/deqp_support/deqp_gles2_test_expectations.txt

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,16 @@
7070
//
7171
////////////////////////////////////////////////////////////////////////////////
7272

73+
// Failures related to the depth_range on Windows / NVIDIA and ATI.
74+
2426 D3D11 : dEQP-GLES2.functional.depth_range.write.reverse = FAIL
75+
2426 D3D11 : dEQP-GLES2.functional.depth_range.write.half_to_zero = FAIL
76+
2426 D3D11 : dEQP-GLES2.functional.depth_range.write.one_to_half = FAIL
77+
2426 D3D11 : dEQP-GLES2.functional.depth_range.write.0_8_to_third = FAIL
78+
2426 D3D11 : dEQP-GLES2.functional.depth_range.compare.reverse = FAIL
79+
2426 D3D11 : dEQP-GLES2.functional.depth_range.compare.half_to_zero = FAIL
80+
2426 D3D11 : dEQP-GLES2.functional.depth_range.compare.one_to_half = FAIL
81+
2426 D3D11 : dEQP-GLES2.functional.depth_range.compare.0_8_to_third = FAIL
82+
7383
// Only fails in D3D11 32-bit.
7484
1418 D3D11 : dEQP-GLES2.functional.clipping.triangle_vertex.clip_three.clip_pos_x_pos_y_pos_z_and_neg_x_pos_y_pos_z_and_neg_x_neg_y_neg_z = FAIL
7585

@@ -348,4 +358,8 @@
348358
2161 VULKAN : dEQP-GLES2.functional.draw.random.* = SKIP
349359
2161 VULKAN : dEQP-GLES2.functional.default_vertex_attrib.* = SKIP
350360
2161 VULKAN : dEQP-GLES2.functional.lifetime.* = SKIP
351-
2161 VULKAN : dEQP-GLES2.functional.debug_marker.* = SKIP
361+
2161 VULKAN : dEQP-GLES2.functional.debug_marker.* = SKIP
362+
363+
// Scissored depth/stencil clear isn't implemented yet.
364+
2427 VULKAN : dEQP-GLES2.functional.fragment_ops.scissor.clear_depth = SKIP
365+
2427 VULKAN : dEQP-GLES2.functional.fragment_ops.scissor.clear_stencil = SKIP

src/tests/deqp_support/deqp_gles3_test_expectations.txt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,18 @@
4949
//
5050
////////////////////////////////////////////////////////////////////////////////
5151

52+
// Failures related to using a depth/stencil enabled backbuffer on Windows / NVIDIA.
53+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.shaders.invariance.highp.common_subexpression_1 = FAIL
54+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.shaders.invariance.mediump.common_subexpression_1 = FAIL
55+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.shaders.invariance.lowp.common_subexpression_1 = FAIL
56+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.fbo.invalidate.default.render_all = SKIP
57+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.fbo.invalidate.default.render_depth_stencil = SKIP
58+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.fbo.invalidate.default.bind_depth_stencil = SKIP
59+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.fbo.invalidate.default.draw_framebuffer_all = SKIP
60+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.fbo.invalidate.default.read_framebuffer_all = SKIP
61+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.fbo.invalidate.default.bind_all = SKIP
62+
2428 D3D11 NVIDIA : dEQP-GLES3.functional.polygon_offset.default_render_with_units = SKIP
63+
5264
// TODO(jmadill): Find why this fails when run in a certain sequence, but not singly.
5365
1098 WIN : dEQP-GLES3.functional.uniform_api.random.50 = FAIL
5466

0 commit comments

Comments
 (0)