Skip to content

Commit 6382f0e

Browse files
authored
Use dash.log to combine logs with dart (#8638)
Follow up to flutter/dart-intellij-third-party#114
1 parent 8a0804d commit 6382f0e

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
### Changed
66

7+
- Made log file `dash.log` (instead of `flutter.log`).
8+
79
### Removed
810

911
### Fixed

src/io/flutter/FlutterErrorReportSubmitter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.intellij.openapi.project.Project;
2222
import com.intellij.openapi.vfs.VirtualFile;
2323
import com.intellij.util.Consumer;
24+
import io.flutter.logging.PluginLogger;
2425
import io.flutter.run.daemon.DaemonApi;
2526
import io.flutter.sdk.FlutterSdk;
2627
import org.jetbrains.annotations.NotNull;
@@ -181,7 +182,7 @@ public boolean submit(@NotNull IdeaLoggingEvent @NotNull [] events,
181182
builder.append("```\n");
182183
try {
183184
final String logPath = PathManager.getLogPath();
184-
final File logFile = new File(logPath, "flutter.log");
185+
final File logFile = new File(logPath, PluginLogger.LOG_FILE_NAME);
185186
if (logFile.exists()) {
186187
final List<String> lines = Files.readAllLines(logFile.toPath(), StandardCharsets.UTF_8);
187188
final int count = 200;

src/io/flutter/logging/PluginLogger.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66
package io.flutter.logging;
77

8-
import com.intellij.openapi.application.ApplicationManager;
98
import com.intellij.openapi.application.PathManager;
109
import com.intellij.openapi.diagnostic.LogLevel;
1110
import com.intellij.openapi.diagnostic.Logger;
@@ -18,7 +17,7 @@
1817
import java.util.logging.SimpleFormatter;
1918

2019
public class PluginLogger {
21-
private static final String LOG_FILE_NAME = "flutter.log";
20+
public static final String LOG_FILE_NAME = "dash.log";
2221

2322
// This handler specifies the logging format and location.
2423
private static final FileHandler fileHandler;

0 commit comments

Comments
 (0)