Golden image results not matching local results #135507
Labels
dependency: skia
Skia team may need to help us
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
Comments
8 tasks
|
I pushed another commit to the PR and the skiagold discrepancies were resolved. I'm not sure about the order of operations that were required to create this. The most concerning part of the bug is that the incorrect hash was reported in the github comment. I can understand it getting confused about what version it's testing, but it should never report the wrong hash in the comment. |
|
Filed skiabug: https://g-issues.skia.org/issues/302145325 |
chinmaygarde
added
P2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The
https://github.com/flutter/engine/pull/46167#issuecomment-1734648742comment mentions the correct hash but these incorrect results could also be explained by the test having run on a previous commit. Either skiagold got goofed about what code it was testing after a rebase or there are some fundamental differences between playgrounds and the skiagold harness.Seen in: flutter/engine#46167
Local results
Skia gold results
The text was updated successfully, but these errors were encountered: