Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] Fix null-check error in DWDS when debugging Flutter widgets from VS Code (stable) #140712

Closed
elliette opened this issue Dec 28, 2023 · 1 comment
Assignees
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: merged Cherry-pick has been merged to the release branch. cp: review Cherry-picks in the review queue

Comments

@elliette
Copy link
Member

Issue Link

dart-lang/webdev#2297

Target

stable

PR Link

#140711

Changelog Description

Updates DWDS (dependency of flutter_tools) to a hotfix release version. This hotfix release version is identical to the current DWDS version in Flutter stable, except it includes a fix for a null-cast error. See https://pub.dev/packages/dwds/versions/21.0.0+1/changelog

Impacted Users

Flutter developers debugging Flutter widgets from VS Code

Impact Description

Null-cast error displayed in VS Code when a developer tries to inspect a widget's state or build context, see dart-lang/webdev#2297

Workaround

No, it doesn't seem like the proposed workaround is working for all users, see comments after dart-lang/webdev#2297 (comment)

Risk

low

Test Coverage

yes

Validation Steps

Inspect a widget's state or build context from VS Code and verify that you don't see a null-cast error

@elliette elliette added the cp: review Cherry-picks in the review queue label Dec 28, 2023
@elliette elliette changed the title [CP] Fix null-check error in DWDS when debugging Flutter widgets from VS Code [CP] Fix null-check error in DWDS when debugging Flutter widgets from VS Code (stable) Dec 28, 2023
@CaseyHillers CaseyHillers added the cp: approved Approved cherry-pick request label Jan 3, 2024
@CaseyHillers CaseyHillers added the cp: merged Cherry-pick has been merged to the release branch. label Jan 8, 2024
@godofredoc godofredoc added the cp: merge-to-stable Cherry-picks that should be merged to stable label Jan 9, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: merged Cherry-pick has been merged to the release branch. cp: review Cherry-picks in the review queue
Projects
None yet
Development

No branches or pull requests

3 participants