Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some microbenchmarks stopped sending data #45732

Closed
LongCatIsLooong opened this issue Nov 27, 2019 · 9 comments · Fixed by #45743, #50488 or #53153
Closed

Some microbenchmarks stopped sending data #45732

LongCatIsLooong opened this issue Nov 27, 2019 · 9 comments · Fixed by #45743, #50488 or #53153
Labels
a: tests "flutter test", flutter_test, or one of our tests c: regression It was better in the past than it is now tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@LongCatIsLooong
Copy link
Contributor

2019-11-27-140830_2529x473_scrot

Started happening since 5df4b7d

@blasten @liyuqian

@Hixie
Copy link
Contributor

Hixie commented Nov 27, 2019

@liyuqian suggests this is because flutter run xxx.dart is ignoring the xxx.dart. If this is true then this is a stop-ship regression.

@Hixie Hixie added RELEASE BLOCKER tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 27, 2019
@Hixie Hixie added this to the Goals milestone Nov 27, 2019
@blasten
Copy link

blasten commented Nov 27, 2019

@Hixie I'm looking at this issue. I doesn't seem flutter run is ignoring the entrypoint. As you noted, it's very likely that this issue is caused by #45307 (comment).

@xster
Copy link
Member

xster commented Nov 27, 2019

flutter run -t xxx seems to work for me on head as well`

@blasten
Copy link

blasten commented Nov 27, 2019

The issue is that the test relies on the flutter run stdout. In verbose mode, flutter run stdout also includes the device's stdout (from the device logger) which used to skip logs that were older than the flutter run command invocation. In my change, I forwarded all the device logs that have the "flutter" tag, so that isn't what the test expects.

@liyuqian
Copy link
Contributor

I just confirmed that flutter run xxx.dart worked for me too. Sorry for giving you the wrong suggestion because I tried to modify the running target in microbenchmarks.dart and saw the result of dart bin/run.dart -t microbenchmarks to be not changed. Now I understand that the result doesn't change because we're always reading the old log...

@Hixie Hixie added a: tests "flutter test", flutter_test, or one of our tests c: regression It was better in the past than it is now and removed RELEASE BLOCKER labels Nov 27, 2019
@Hixie
Copy link
Contributor

Hixie commented Nov 27, 2019

Ok, good. Removing panic markers.

Can we return to the previous behaviour? We didn't have the old behaviour just randomly, it was very much intentional that flutter logs and flutter run not give you old logs. :-)

@blasten
Copy link

blasten commented Nov 28, 2019

The microbenchmarks are back!

@Hixie
Copy link
Contributor

Hixie commented Nov 28, 2019

Yay! Thanks for fixing this on your day off! Please definitely don't feel you must do that, but it is appreciated! :-)

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests c: regression It was better in the past than it is now tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
5 participants