Skip to content

Make sure that a FlutterLogo doesn't crash in 0x0 environment #180617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jan 12, 2026
Merged

Make sure that a FlutterLogo doesn't crash in 0x0 environment #180617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/flutter/test/widgets/flutter_logo_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,14 @@ void main() {

await expectLater(find.byKey(logo), matchesGoldenFile('flutter_logo.png'));
});

testWidgets('FlutterLogo does not crash at zero area', (WidgetTester tester) async {
await tester.pumpWidget(
const Directionality(
textDirection: TextDirection.ltr,
child: Center(child: SizedBox.shrink(child: FlutterLogo())),
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Center widget is redundant here. SizedBox.shrink() already constrains its child to a 0x0 size, so the Center widget has no effect on the layout of the FlutterLogo. Removing it will make the test's widget tree more minimal and focused on the specific scenario being tested.

        child: SizedBox.shrink(child: FlutterLogo()),

),
);
expect(tester.getSize(find.byType(FlutterLogo)), Size.zero);
});
}