Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Shrine crashes when scrolling on desktop #541

Closed
Piinks opened this issue Sep 8, 2021 · 0 comments · Fixed by #542
Closed

Shrine crashes when scrolling on desktop #541

Piinks opened this issue Sep 8, 2021 · 0 comments · Fixed by #542
Assignees
Labels
bug Something isn't working

Comments

@Piinks
Copy link
Contributor

Piinks commented Sep 8, 2021

Shrine crashes when you scroll on desktop. This is caused by the scrollbars that are automatically applied on desktop platforms. There are scroll views in Shrine that are all using the same scroll controller, so when it tries to draw one scrollbar for all of those scroll views it crashes.

This is most likely due to the PrimaryScrollController. All vertical scroll views that have not been provided a scroll controller automatically attach to the PrimaryScrollController. If each scroll view is provided a unique scroll controller, the desktop scrollbars won't have an issue. I am opening a PR now to disable them and fix the crash until that work can be done.

Related: #523

@Piinks Piinks added the bug Something isn't working label Sep 8, 2021
@Piinks Piinks self-assigned this Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant