Delint and stuff.

Author: matanlurey

packages/video_player/video_player_android/CHANGELOG.md

@@ -1,172 +1,176 @@
+## 2.7.0
+
+- Re-adds [support for Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).
+
 ## 2.6.0
 
-* Adds RTSP support.
+- Adds RTSP support.
 
 ## 2.5.4
 
-* Updates Media3-ExoPlayer to 1.4.0.
+- Updates Media3-ExoPlayer to 1.4.0.
 
 ## 2.5.3
 
-* Updates lint checks to ignore NewerVersionAvailable.
+- Updates lint checks to ignore NewerVersionAvailable.
 
 ## 2.5.2
 
-* Updates Android Gradle plugin to 8.5.0.
+- Updates Android Gradle plugin to 8.5.0.
 
 ## 2.5.1
 
-* Removes additional references to the v1 Android embedding.
+- Removes additional references to the v1 Android embedding.
 
 ## 2.5.0
 
-* Migrates ExoPlayer to Media3-ExoPlayer 1.3.1.
+- Migrates ExoPlayer to Media3-ExoPlayer 1.3.1.
 
 ## 2.4.17
 
-* Revert Impeller support.
+- Revert Impeller support.
 
 ## 2.4.16
 
-* [Supports Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).
+- [Supports Impeller](https://docs.flutter.dev/release/breaking-changes/android-surface-plugins).
 
 ## 2.4.15
 
-* Updates minimum supported SDK version to Flutter 3.22/Dart 3.4.
-* Removes support for apps using the v1 Android embedding.
+- Updates minimum supported SDK version to Flutter 3.22/Dart 3.4.
+- Removes support for apps using the v1 Android embedding.
 
 ## 2.4.14
 
-* Calls `onDestroy` instead of `initialize` in onDetachedFromEngine.
+- Calls `onDestroy` instead of `initialize` in onDetachedFromEngine.
 
 ## 2.4.13
 
-* Updates minSdkVersion to 19.
-* Updates minimum supported SDK version to Flutter 3.16/Dart 3.2.
+- Updates minSdkVersion to 19.
+- Updates minimum supported SDK version to Flutter 3.16/Dart 3.2.
 
 ## 2.4.12
 
-* Updates compileSdk version to 34.
-* Adds error handling for `BehindLiveWindowException`, which may occur upon live-video playback failure.
+- Updates compileSdk version to 34.
+- Adds error handling for `BehindLiveWindowException`, which may occur upon live-video playback failure.
 
 ## 2.4.11
 
-* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
-* Fixes new lint warnings.
+- Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
+- Fixes new lint warnings.
 
 ## 2.4.10
 
-* Adds pub topics to package metadata.
-* Updates minimum supported SDK version to Flutter 3.7/Dart 2.19.
+- Adds pub topics to package metadata.
+- Updates minimum supported SDK version to Flutter 3.7/Dart 2.19.
 
 ## 2.4.9
 
-* Bumps ExoPlayer version to 2.18.7.
+- Bumps ExoPlayer version to 2.18.7.
 
 ## 2.4.8
 
-* Bumps ExoPlayer version to 2.18.6.
+- Bumps ExoPlayer version to 2.18.6.
 
 ## 2.4.7
 
-* Fixes Java warnings.
+- Fixes Java warnings.
 
 ## 2.4.6
 
-* Fixes compatibility with AGP versions older than 4.2.
+- Fixes compatibility with AGP versions older than 4.2.
 
 ## 2.4.5
 
-* Adds a namespace for compatibility with AGP 8.0.
+- Adds a namespace for compatibility with AGP 8.0.
 
 ## 2.4.4
 
-* Synchronizes `VideoPlayerValue.isPlaying` with `ExoPlayer`.
-* Updates minimum Flutter version to 3.3.
+- Synchronizes `VideoPlayerValue.isPlaying` with `ExoPlayer`.
+- Updates minimum Flutter version to 3.3.
 
 ## 2.4.3
 
-* Bumps ExoPlayer version to 2.18.5.
+- Bumps ExoPlayer version to 2.18.5.
 
 ## 2.4.2
 
-* Bumps ExoPlayer version to 2.18.4.
+- Bumps ExoPlayer version to 2.18.4.
 
 ## 2.4.1
 
-* Changes the severity of `javac` warnings so that they are treated as errors and fixes the violations.
+- Changes the severity of `javac` warnings so that they are treated as errors and fixes the violations.
 
 ## 2.4.0
 
-* Allows setting the ExoPlayer user agent by passing a User-Agent HTTP header.
+- Allows setting the ExoPlayer user agent by passing a User-Agent HTTP header.
 
 ## 2.3.12
 
-* Clarifies explanation of endorsement in README.
-* Aligns Dart and Flutter SDK constraints.
-* Updates compileSdkVersion to 33.
+- Clarifies explanation of endorsement in README.
+- Aligns Dart and Flutter SDK constraints.
+- Updates compileSdkVersion to 33.
 
 ## 2.3.11
 
-* Updates links for the merge of flutter/plugins into flutter/packages.
-* Updates minimum Flutter version to 3.0.
+- Updates links for the merge of flutter/plugins into flutter/packages.
+- Updates minimum Flutter version to 3.0.
 
 ## 2.3.10
 
-* Adds compatibilty with version 6.0 of the platform interface.
-* Fixes file URI construction in example.
-* Updates code for new analysis options.
-* Updates code for `no_leading_underscores_for_local_identifiers` lint.
-* Updates minimum Flutter version to 2.10.
-* Fixes violations of new analysis option use_named_constants.
-* Removes an unnecessary override in example code.
+- Adds compatibilty with version 6.0 of the platform interface.
+- Fixes file URI construction in example.
+- Updates code for new analysis options.
+- Updates code for `no_leading_underscores_for_local_identifiers` lint.
+- Updates minimum Flutter version to 2.10.
+- Fixes violations of new analysis option use_named_constants.
+- Removes an unnecessary override in example code.
 
 ## 2.3.9
 
-* Updates ExoPlayer to 2.18.1.
-* Fixes avoid_redundant_argument_values lint warnings and minor typos.
+- Updates ExoPlayer to 2.18.1.
+- Fixes avoid_redundant_argument_values lint warnings and minor typos.
 
 ## 2.3.8
 
-* Updates ExoPlayer to 2.18.0.
+- Updates ExoPlayer to 2.18.0.
 
 ## 2.3.7
 
-* Bumps gradle version to 7.2.1.
-* Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/106316).
+- Bumps gradle version to 7.2.1.
+- Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/106316).
 
 ## 2.3.6
 
-* Updates references to the obsolete master branch.
+- Updates references to the obsolete master branch.
 
 ## 2.3.5
 
-* Sets rotationCorrection for videos recorded in landscapeRight (https://github.com/flutter/flutter/issues/60327).
+- Sets rotationCorrection for videos recorded in landscapeRight (https://github.com/flutter/flutter/issues/60327).
 
 ## 2.3.4
 
-* Updates ExoPlayer to 2.17.1.
+- Updates ExoPlayer to 2.17.1.
 
 ## 2.3.3
 
-* Removes unnecessary imports.
-* Fixes library_private_types_in_public_api, sort_child_properties_last and use_key_in_widget_constructors
+- Removes unnecessary imports.
+- Fixes library_private_types_in_public_api, sort_child_properties_last and use_key_in_widget_constructors
   lint warnings.
 
 ## 2.3.2
 
-* Updates ExoPlayer to 2.17.0.
+- Updates ExoPlayer to 2.17.0.
 
 ## 2.3.1
 
-* Renames internal method channels to avoid potential confusion with the
+- Renames internal method channels to avoid potential confusion with the
   default implementation's method channel.
-* Updates Pigeon to 2.0.1.
+- Updates Pigeon to 2.0.1.
 
 ## 2.3.0
 
-* Updates Pigeon to ^1.0.16.
+- Updates Pigeon to ^1.0.16.
 
 ## 2.2.17
 
-* Splits from `video_player` as a federated implementation.
+- Splits from `video_player` as a federated implementation.

packages/video_player/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java

@@ -85,7 +85,7 @@ interface ExoPlayerProvider {
         new TextureRegistry.SurfaceProducer.Callback() {
           @Override
           public void onSurfaceCreated() {
-            exoPlayer = createVideoPlayer();
+            setExoPlayer(createVideoPlayer());
             if (savedStateDuring != null) {
               savedStateDuring.restore(exoPlayer);
               savedStateDuring = null;
@@ -101,6 +101,11 @@ public void onSurfaceDestroyed() {
         });
   }
 
+  // Used to avoid synthetic accessor.
+  private void setExoPlayer(@NonNull ExoPlayer exoPlayer) {
+    this.exoPlayer = exoPlayer;
+  }
+
   private ExoPlayer createVideoPlayer() {
     ExoPlayer exoPlayer = exoPlayerProvider.get();
     exoPlayer.setMediaItem(mediaItem);

packages/video_player/video_player_android/pubspec.yaml

@@ -2,7 +2,7 @@ name: video_player_android
 description: Android implementation of the video_player plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
-version: 2.6.0
+version: 2.7.0
 
 environment:
   sdk: ^3.4.0