Revert "test failures"

This reverts commit d329678b5be29c3c03ac0d3e9dc18d3bc0d8d154.

Author: jmagman

packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m

@@ -191,7 +191,6 @@ - (void)testBlankVideoBugWithEncryptedVideoStreamAndInvertedAspectRatioBugForSom
 }
 
 - (void)testSeekToWhilePausedStartsDisplayLinkTemporarily {
-  XCTFail(@"Failing to test xcresult upload");
   NSObject<FlutterTextureRegistry> *mockTextureRegistry =
       OCMProtocolMock(@protocol(FlutterTextureRegistry));
   NSObject<FlutterPluginRegistrar> *registrar =

packages/video_player/video_player_avfoundation/example/integration_test/video_player_test.dart

@@ -133,8 +133,7 @@ void main() {
       await controller.play();
       await tester.pumpAndSettle(_playDuration);
 
-      // test xcresult upload
-      expect(await controller.position, lessThan(Duration.zero));
+      expect(await controller.position, greaterThan(Duration.zero));
     });
   });
 

packages/video_player/video_player_avfoundation/example/ios/Runner/AppDelegate.m

@@ -9,8 +9,6 @@ @implementation AppDelegate
 
 - (BOOL)application:(UIApplication *)application
     didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
-  // Test analyzer warning still works.
-  BOOL x = @"true";
   [GeneratedPluginRegistrant registerWithRegistry:self];
   // Override point for customization after application launch.
   return [super application:application didFinishLaunchingWithOptions:launchOptions];