Skip to content

Commit 5414ef4

Browse files
authored
Hide unresolved DartUri log messages (#102338)
1 parent ca3b406 commit 5414ef4

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

packages/flutter_tools/lib/src/isolated/devfs_web.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,6 +1009,16 @@ void _log(logging.LogRecord event) {
10091009
if (event.level >= logging.Level.SEVERE) {
10101010
globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace);
10111011
} else if (event.level == logging.Level.WARNING) {
1012+
// TODO(elliette): Remove the following message suppressions after DWDS is
1013+
// >13.1.0, https://github.com/flutter/flutter/issues/101639
1014+
const String dartUri = 'DartUri';
1015+
if (event.loggerName == dartUri) {
1016+
const String webSqlWarning = 'Unresolved uri: dart:web_sql';
1017+
const String uiWarning = 'Unresolved uri: dart:ui';
1018+
if (event.message == webSqlWarning || event.message == uiWarning) {
1019+
return;
1020+
}
1021+
}
10121022
globals.printWarning('${event.loggerName}: ${event.message}$error');
10131023
} else {
10141024
globals.printTrace('${event.loggerName}: ${event.message}$error');

packages/flutter_tools/test/web.shard/output_web_test.dart

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,18 @@ void main() {
7878
await sendEvent(<String, Object>{'type': 'DevtoolsEvent'});
7979
await warning;
8080
}, skip: true); // Skipping for 'https://github.com/dart-lang/webdev/issues/1562'
81+
82+
testWithoutContext(
83+
'flutter run output skips DartUri warning messages from dwds', () async {
84+
bool containsDartUriWarning = false;
85+
flutter.stderr.listen((String msg) {
86+
if (msg.contains('DartUri')) {
87+
containsDartUriWarning = true;
88+
}
89+
});
90+
await start();
91+
await flutter.stop();
92+
expect(containsDartUriWarning, isFalse);
93+
// TODO(elliette): Enable for DWDS >13.1.0, https://github.com/flutter/flutter/issues/101639
94+
}, skip: true); // [intended] enable for DWDS >13.1.0
8195
}

0 commit comments

Comments
 (0)